RDMA/mlx5: Fix type warning of sizeof in __mlx5_ib_alloc_counters()
authorLiu Shixin <liushixin2@huawei.com>
Thu, 17 Sep 2020 08:13:54 +0000 (16:13 +0800)
committerJason Gunthorpe <jgg@nvidia.com>
Fri, 25 Sep 2020 12:17:42 +0000 (09:17 -0300)
sizeof() when applied to a pointer typed expression should give the size
of the pointed data, even if the data is a pointer.

Fixes: e1f24a79f424 ("IB/mlx5: Support congestion related counters")
Link: https://lore.kernel.org/r/20200917081354.2083293-1-liushixin2@huawei.com
Signed-off-by: Liu Shixin <liushixin2@huawei.com>
Acked-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/mlx5/counters.c

index 8d77fea..70c8fd6 100644 (file)
@@ -457,12 +457,12 @@ static int __mlx5_ib_alloc_counters(struct mlx5_ib_dev *dev,
                cnts->num_ext_ppcnt_counters = ARRAY_SIZE(ext_ppcnt_cnts);
                num_counters += ARRAY_SIZE(ext_ppcnt_cnts);
        }
-       cnts->names = kcalloc(num_counters, sizeof(cnts->names), GFP_KERNEL);
+       cnts->names = kcalloc(num_counters, sizeof(*cnts->names), GFP_KERNEL);
        if (!cnts->names)
                return -ENOMEM;
 
        cnts->offsets = kcalloc(num_counters,
-                               sizeof(cnts->offsets), GFP_KERNEL);
+                               sizeof(*cnts->offsets), GFP_KERNEL);
        if (!cnts->offsets)
                goto err_names;