good: use of g_value_dup_string

Use helper method to get string from GValue.

diff --git a/ext/shout2/gstshout2.c b/ext/shout2/gstshout2.c
index bda93b9b146259dc18e6f214906059ba7236cca4..adfaccf7a51d9e9782abb7f6a6aee978b7900eba 100644 (file)
--- a/ext/shout2/gstshout2.c
+++ b/ext/shout2/gstshout2.c
@@ -803,44 +803,44 @@ gst_shout2send_set_property (GObject * object, guint prop_id,
 
     case ARG_IP:
       g_free (shout2send->ip);
-      shout2send->ip = g_strdup (g_value_get_string (value));
+      shout2send->ip = g_value_dup_string (value);
       break;
     case ARG_PORT:
       shout2send->port = g_value_get_int (value);
       break;
     case ARG_PASSWORD:
       g_free (shout2send->password);
-      shout2send->password = g_strdup (g_value_get_string (value));
+      shout2send->password = g_value_dup_string (value);
       break;
     case ARG_USERNAME:
       g_free (shout2send->username);
-      shout2send->username = g_strdup (g_value_get_string (value));
+      shout2send->username = g_value_dup_string (value);
       break;
     case ARG_PUBLIC:
       shout2send->ispublic = g_value_get_boolean (value);
       break;
     case ARG_STREAMNAME:       /* Name of the stream */
       g_free (shout2send->streamname);
-      shout2send->streamname = g_strdup (g_value_get_string (value));
+      shout2send->streamname = g_value_dup_string (value);
       break;
     case ARG_DESCRIPTION:      /* Description of the stream */
       g_free (shout2send->description);
-      shout2send->description = g_strdup (g_value_get_string (value));
+      shout2send->description = g_value_dup_string (value);
       break;
     case ARG_GENRE:            /* Genre of the stream */
       g_free (shout2send->genre);
-      shout2send->genre = g_strdup (g_value_get_string (value));
+      shout2send->genre = g_value_dup_string (value);
       break;
     case ARG_PROTOCOL:         /* protocol to connect with */
       shout2send->protocol = g_value_get_enum (value);
       break;
     case ARG_MOUNT:            /* mountpoint of stream (icecast only) */
       g_free (shout2send->mount);
-      shout2send->mount = g_strdup (g_value_get_string (value));
+      shout2send->mount = g_value_dup_string (value);
       break;
     case ARG_URL:              /* the stream's homepage URL */
       g_free (shout2send->url);
-      shout2send->url = g_strdup (g_value_get_string (value));
+      shout2send->url = g_value_dup_string (value);
       break;
     case ARG_TIMEOUT:
       shout2send->timeout = g_value_get_uint (value);

diff --git a/gst/multipart/multipartmux.c b/gst/multipart/multipartmux.c
index f213cb587006de52d1a8326f04e7637982fe6dc0..e76ccc013a13f988b9b5cb0f0a112b5d2777cb12 100644 (file)
--- a/gst/multipart/multipartmux.c
+++ b/gst/multipart/multipartmux.c
@@ -639,7 +639,7 @@ gst_multipart_mux_set_property (GObject * object,
   switch (prop_id) {
     case PROP_BOUNDARY:
       g_free (mux->boundary);
-      mux->boundary = g_strdup (g_value_get_string (value));
+      mux->boundary = g_value_dup_string (value);
       break;
     default:
       G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);

diff --git a/sys/ximage/gstximagesrc.c b/sys/ximage/gstximagesrc.c
index 8113a2a5a80d72cdd3273e31a9ecabdc476cdafd..b97d82c0d4b0e9fdae86957ccdf4520c3954b7f1 100644 (file)
--- a/sys/ximage/gstximagesrc.c
+++ b/sys/ximage/gstximagesrc.c
@@ -929,7 +929,7 @@ gst_ximage_src_set_property (GObject * object, guint prop_id,
     case PROP_DISPLAY_NAME:
 
       g_free (src->display_name);
-      src->display_name = g_strdup (g_value_get_string (value));
+      src->display_name = g_value_dup_string (value);
       break;
     case PROP_SHOW_POINTER:
       src->show_pointer = g_value_get_boolean (value);
@@ -965,7 +965,7 @@ gst_ximage_src_set_property (GObject * object, guint prop_id,
         break;
       }
       g_free (src->xname);
-      src->xname = g_strdup (g_value_get_string (value));
+      src->xname = g_value_dup_string (value);
       break;
     default:
       break;