camerabin2: preview: remove redundant property setting on appsink
authorRatchanan Srirattanamet <peathot@hotmail.com>
Thu, 29 Aug 2019 14:20:37 +0000 (21:20 +0700)
committerTim-Philipp Müller <tim@centricular.com>
Sun, 20 Oct 2019 20:07:04 +0000 (20:07 +0000)
Commit 8a56a7de6d5f2cf70dbe6efbd7c8ed74600c8565 (camerabin2: preview:
Appsink doesn't need to sync) add a line that set the "sync" property on
the appsink. However, the author seems to forget that there's another
property setting on appsink a few lines below.

It's very likely that the added line is required because the original
line doesn't take effect (maybe because it's too late). But for whatever
reason, the original line is now redundant. So, I remove it in this
commit.

gst-libs/gst/basecamerabinsrc/gstcamerabinpreview.c

index 6d8545f..e29a7b2 100644 (file)
@@ -194,8 +194,6 @@ gst_camerabin_create_preview_pipeline (GstElement * element,
   gst_bus_add_watch (bus, bus_callback, data);
   gst_object_unref (bus);
 
-  g_object_set (data->appsink, "sync", FALSE, NULL);
-
   data->element = element;
   data->filter = filter;
   data->vscale = vscale;