Fix svace issues

- MEMORY_LEAK
- INCORRECT_PERMISSION

Change-Id: I6b168f48652ac879b80f777d4c711abedf9c7806

diff --git a/src/download-mgr-main.cpp b/src/download-mgr-main.cpp
index f258fec..72e1c82 100644 (file)
--- a/src/download-mgr-main.cpp
+++ b/src/download-mgr-main.cpp
@@ -332,6 +332,7 @@ static void __app_control(app_control_h s, void *data)
                        unsigned int id = (int) strtol(historyid_str, &end_ptr, 0);
                        if (ERANGE == errno) {
                                DM_LOGE("HistoryId String conversion failed");
+                               free(historyid_str);
                                return;
                        }
                        DM_LOGI("History Id from downloading noti[%s]", historyid_str);

diff --git a/src/download-mgr-util.cpp b/src/download-mgr-util.cpp
index aeb8006..4cc8446 100644 (file)
--- a/src/download-mgr-util.cpp
+++ b/src/download-mgr-util.cpp
@@ -339,7 +339,7 @@ bool FileUtility::checkTempDir(string userInstallDir)
 
        DM_SLOGD("temp dir:[%s]", defaultDir.c_str());
        if (!isExistedFile(defaultDir, true)) {
-               if (mkdir(defaultDir.c_str(), 755)) {
+               if (mkdir(defaultDir.c_str(), 644)) {
                        DM_LOGE("Fail to create directory");
                        return false;
                } else {