wil6210: do not reset FW in STA to P2P client interface switch
authorAlexei Avshalom Lazar <ailizaro@codeaurora.org>
Sun, 16 Jun 2019 07:25:57 +0000 (10:25 +0300)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 27 Jun 2019 17:49:34 +0000 (20:49 +0300)
Currently the FW is reset on every interface type change, because
of various FW bugs.
FW reset is not required when switching from STA to P2P client, hence
can be skipped.

Signed-off-by: Alexei Avshalom Lazar <ailizaro@codeaurora.org>
Signed-off-by: Maya Erez <merez@codeaurora.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/wil6210/cfg80211.c

index ca77d7a..f94fe42 100644 (file)
@@ -643,6 +643,16 @@ out:
        return rc;
 }
 
+static bool wil_is_safe_switch(enum nl80211_iftype from,
+                              enum nl80211_iftype to)
+{
+       if (from == NL80211_IFTYPE_STATION &&
+           to == NL80211_IFTYPE_P2P_CLIENT)
+               return true;
+
+       return false;
+}
+
 static int wil_cfg80211_change_iface(struct wiphy *wiphy,
                                     struct net_device *ndev,
                                     enum nl80211_iftype type,
@@ -668,7 +678,8 @@ static int wil_cfg80211_change_iface(struct wiphy *wiphy,
         * because it can cause significant disruption
         */
        if (!wil_has_other_active_ifaces(wil, ndev, true, false) &&
-           netif_running(ndev) && !wil_is_recovery_blocked(wil)) {
+           netif_running(ndev) && !wil_is_recovery_blocked(wil) &&
+           !wil_is_safe_switch(wdev->iftype, type)) {
                wil_dbg_misc(wil, "interface is up. resetting...\n");
                mutex_lock(&wil->mutex);
                __wil_down(wil);