Add assertation check for Tcs

Change-Id: If4dfb627124288e2a06cf5496cdae4edf22da5b5
Signed-off-by: biao716.wang <biao716.wang@samsung.com>

diff --git a/tests/test_config.py b/tests/test_config.py
index 88a2949f8df24dd8b02715a9ff006be2dab9f8f8..a3df33149f15efc8b680595e8196b3575917d5e7 100644 (file)
--- a/tests/test_config.py
+++ b/tests/test_config.py
@@ -161,56 +161,70 @@ class ConfigGettingTest(unittest.TestCase):
         '''test get obs meta by class MappingConfigParser'''
         mapparser = MappingConfigParser('/usr/share/gbs/mapping.conf')
         obs_meta = mapparser.GetObsMapping()
+        self.assertTrue(obs_meta)
 
     def test_MappingConfigParser_prefix_meta_(self):
         '''test get prefix meta by class MappingConfigParser'''
         mapparser = MappingConfigParser('/usr/share/gbs/mapping.conf')
         obs_meta = mapparser.GetObsMapping()
+        self.assertTrue(obs_meta)
 
     def test_MappingConfigParser_repo_meta_(self):
         '''test get repo meta by class MappingConfigParser'''
         mapparser = MappingConfigParser('/usr/share/gbs/mapping.conf')
         obs_meta = mapparser.GetObsMapping()
+        self.assertTrue(obs_meta)
 
     def test_MappingConfigParser_profile_meta_(self):
         '''test get profile  meta by class MappingConfigParser'''
         mapparser = MappingConfigParser('/usr/share/gbs/mapping.conf')
         obs_meta = mapparser.GetObsMapping()
+        self.assertTrue(obs_meta)
+
 
     def test_MappingConfigParser_source_meta_(self):
         '''test get source meta by class MappingConfigParser'''
         mapparser = MappingConfigParser('/usr/share/gbs/mapping.conf')
         obs_meta = mapparser.GetObsMapping()
+        self.assertTrue(obs_meta)
+
 
     def test_MappingConfigParser_obs_meta_(self):
         '''test get obs meta by class MappingConfigParser'''
         mapparser = MappingConfigParser('/usr/share/gbs/mapping.conf')
         obs_meta = mapparser.GetObsMapping()
+        self.assertTrue(obs_meta)
+
 
     def test_MappingConfigParser_get_prefix_mapping_(self):
         '''test get prefix meta by class MappingConfigParser'''
         mapparser = MappingConfigParser('/usr/share/gbs/mapping.conf')
-        mapparser.GetPrefixMapping()
+        obs_meta = mapparser.GetPrefixMapping()
+        self.assertTrue(obs_meta)
 
     def test_MappingConfigParser_get_repo_mapping_(self):
         '''test get repo meta by class MappingConfigParser'''
         mapparser = MappingConfigParser('/usr/share/gbs/mapping.conf')
         obs_meta = mapparser.GetRepoMapping()
+        self.assertTrue(obs_meta)
 
     def test_MappingConfigParser_get_profile_mapping_(self):
         '''test get profile meta by class MappingConfigParser'''
         mapparser = MappingConfigParser('/usr/share/gbs/mapping.conf')
         obs_meta = mapparser.GetProfileMapping()
+        self.assertTrue(obs_meta)
 
     def test_MappingConfigParser_get_source_mapping_(self):
         '''test get source meta by class MappingConfigParser'''
         mapparser = MappingConfigParser('/usr/share/gbs/mapping.conf')
         obs_meta = mapparser.GetSourceMapping()
+        self.assertTrue(obs_meta)
 
     def test_MappingConfigParser_get_osc_mapping_(self):
         '''test get osc meta by class MappingConfigParser'''
         mapparser = MappingConfigParser('/usr/share/gbs/mapping.conf')
         obs_meta = mapparser.GetOscMapping()
+        self.assertTrue(obs_meta)
 
 
 if __name__ == '__main__':

diff --git a/tests/test_export.py b/tests/test_export.py
index 4e53231b81acca4ab11e521aff30048f5793fbcf..05c5a80216eb1cfc821256ee6696d7992a390f36 100644 (file)
--- a/tests/test_export.py
+++ b/tests/test_export.py
@@ -66,9 +66,11 @@ class TestExport(unittest.TestCase):
 
     def test_config_is_true(self):
         '''test config_is_true fumction'''
-        config_is_true('yes')
-        config_is_true(True)
-        pass
+        try:
+            config_is_true('yes')
+            config_is_true(True)
+        except SystemExit as err:
+            eq_(err.code, 0)
 
     def test_command_export_disable_fallback_to_native_packaging(self):
         """Test running gbs export failed case:disable fallback to native commond."""
@@ -88,6 +90,8 @@ class TestExport(unittest.TestCase):
     @raises(Exception)
     def test_command_export_special_spec(self):
         """Test use Invalid upstream treeish upstream"""
-        os.chdir('/home/build/acl')
-        GBS(argv=["gbs", "export", "--include-all", "-o", "/tmp"])
-        pass
+        try:
+            os.chdir('/home/build/acl')
+            GBS(argv=["gbs", "export", "--include-all", "-o", "/tmp"])
+        except SystemExit as err:
+            eq_(err.code, 0)

diff --git a/tests/test_utils.py b/tests/test_utils.py
index 5eba5897c7782da4df77d01e6e9c562278eba2cb..ff71f15eefe548a5311b3526a843707be13d7cc7 100644 (file)
--- a/tests/test_utils.py
+++ b/tests/test_utils.py
@@ -34,7 +34,7 @@ class UtilsTest(unittest.TestCase):
     def test_urlgrabber(self):
         '''test urlgrabber class'''
         self.urlgrabber = URLGrabber()
-        #self.urlgrabber.perform()
+        self.assertTrue(self.urlgrabber)
 
     def test_repoparser(self):
         '''test repoparser'''
@@ -47,6 +47,7 @@ class UtilsTest(unittest.TestCase):
         repos = [i.url for i in profile.repos]
         repoparser = RepoParser(repos, cachedir)
         repourls = repoparser.get_repos_by_arch('armv7l')
+        self.assertTrue(repourls)
 
     def test_given_profile(self):
         '''test repoparse with certain profile file'''
@@ -62,16 +63,21 @@ class UtilsTest(unittest.TestCase):
         repos = [i.url for i in profile.repos]
         repoparser = RepoParser(repos, cachedir)
         repourls = repoparser.get_repos_by_arch('armv7l')
+        self.assertTrue(repourls)
 
     def test_edit_file(self):
         '''test edit file fuction'''
-        os.system('cp ./tests/testdata/fake.spec editfile')
-        edit_file('editfile')
+        try:
+            os.system('cp ./tests/testdata/fake.spec editfile')
+            edit_file('editfile')
+        except SystemExit as err:
+            eq_(err.code, 0)
 
     def test_GitRefMappingParser(self):
         '''test class GitRefMappingParser'''
         refparser = GitRefMappingParser()
         ref_meta = refparser.parse()
+        self.assertTrue(ref_meta)
 
     def test_GerritNameMapper(self):
         '''test calss GerritNameMapper'''
@@ -91,7 +97,7 @@ class UtilsTest(unittest.TestCase):
         gnmapper.get_gerritname_by_srcname('rpm')
         gnmapper.get_gerritname_by_obsname('rpm')
         gnmapper.get_pkgname_by_srcname('rpm')
-
+        self.assertTrue(gnmapper)
 
 FILE_DIRNAME = os.path.dirname(os.path.abspath(__file__))