net: openvswitch: drop unneeded likely() call around IS_ERR()
authorEnrico Weigelt <info@metux.net>
Wed, 5 Jun 2019 21:06:40 +0000 (23:06 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 5 Jun 2019 23:57:23 +0000 (16:57 -0700)
IS_ERR() already calls unlikely(), so this extra likely() call
around the !IS_ERR() is not needed.

Signed-off-by: Enrico Weigelt <info@metux.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/openvswitch/datapath.c

index dc9ff93..4076e08 100644 (file)
@@ -1347,7 +1347,7 @@ static int ovs_flow_cmd_del(struct sk_buff *skb, struct genl_info *info)
        reply = ovs_flow_cmd_alloc_info((const struct sw_flow_actions __force *) flow->sf_acts,
                                        &flow->id, info, false, ufid_flags);
        if (likely(reply)) {
-               if (likely(!IS_ERR(reply))) {
+               if (!IS_ERR(reply)) {
                        rcu_read_lock();        /*To keep RCU checker happy. */
                        err = ovs_flow_cmd_fill_info(flow, ovs_header->dp_ifindex,
                                                     reply, info->snd_portid,