staging: atomisp: remove redundant check for client being null
authorColin Ian King <colin.king@canonical.com>
Sat, 11 Mar 2017 19:48:19 +0000 (19:48 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 12 Mar 2017 13:57:00 +0000 (14:57 +0100)
The previous statement checks if client is null, so the null check
when assigning dev is redundant and can be removed.

Detected by CoverityScan, CID#1416555 ("Logically Dead Code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c

index 65513ca..2929492 100644 (file)
@@ -354,7 +354,7 @@ static struct gmin_subdev *gmin_subdev_add(struct v4l2_subdev *subdev)
        if (!client)
                return NULL;
 
-       dev = client ? &client->dev : NULL;
+       dev = &client->dev;
 
        for (i=0; i < MAX_SUBDEVS && gmin_subdevs[i].subdev; i++)
                ;