projects
/
platform
/
upstream
/
llvm.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c00ef03
)
[BitstreamReader] Fix incorrect error forwarding
author
Nikita Popov
<npopov@redhat.com>
Fri, 4 Feb 2022 16:30:48 +0000
(17:30 +0100)
committer
Nikita Popov
<npopov@redhat.com>
Fri, 4 Feb 2022 16:31:12 +0000
(17:31 +0100)
This code clearly intended to forward the error, but instead
returned the non-error result.
llvm/lib/Bitstream/Reader/BitstreamReader.cpp
patch
|
blob
|
history
diff --git
a/llvm/lib/Bitstream/Reader/BitstreamReader.cpp
b/llvm/lib/Bitstream/Reader/BitstreamReader.cpp
index
751caa2
..
3865af1
100644
(file)
--- a/
llvm/lib/Bitstream/Reader/BitstreamReader.cpp
+++ b/
llvm/lib/Bitstream/Reader/BitstreamReader.cpp
@@
-101,7
+101,7
@@
Expected<unsigned> BitstreamCursor::skipRecord(unsigned AbbrevID) {
unsigned Code = MaybeCode.get();
Expected<uint32_t> MaybeVBR = ReadVBR(6);
if (!MaybeVBR)
- return MaybeVBR.
get
();
+ return MaybeVBR.
takeError
();
unsigned NumElts = MaybeVBR.get();
for (unsigned i = 0; i != NumElts; ++i)
if (Expected<uint64_t> Res = ReadVBR64(6))