usb: hub: make wait_for_connected() take an int instead of a pointer to int
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 10 Dec 2021 14:20:28 +0000 (17:20 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Dec 2021 10:00:09 +0000 (11:00 +0100)
The wait_for_connected() function doesn't modify "*port1" and there is
no need to pass a pointer.  Just pass the int itself.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211210142028.GB18906@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/hub.c

index e907dfa..53275c4 100644 (file)
@@ -3572,7 +3572,7 @@ static int finish_port_resume(struct usb_device *udev)
  * This routine should only be called when persist is enabled.
  */
 static int wait_for_connected(struct usb_device *udev,
-               struct usb_hub *hub, int *port1,
+               struct usb_hub *hub, int port1,
                u16 *portchange, u16 *portstatus)
 {
        int status = 0, delay_ms = 0;
@@ -3586,7 +3586,7 @@ static int wait_for_connected(struct usb_device *udev,
                }
                msleep(20);
                delay_ms += 20;
-               status = hub_port_status(hub, *port1, portstatus, portchange);
+               status = hub_port_status(hub, port1, portstatus, portchange);
        }
        dev_dbg(&udev->dev, "Waited %dms for CONNECT\n", delay_ms);
        return status;
@@ -3692,7 +3692,7 @@ int usb_port_resume(struct usb_device *udev, pm_message_t msg)
        }
 
        if (udev->persist_enabled)
-               status = wait_for_connected(udev, hub, &port1, &portchange,
+               status = wait_for_connected(udev, hub, port1, &portchange,
                                &portstatus);
 
        status = check_port_resume_type(udev,