r8152: Release firmware if we have an error in probe
authorDouglas Anderson <dianders@chromium.org>
Fri, 20 Oct 2023 21:06:55 +0000 (14:06 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 22 Oct 2023 10:46:18 +0000 (11:46 +0100)
The error handling in rtl8152_probe() is missing a call to release
firmware. Add it in to match what's in the cleanup code in
rtl8152_disconnect().

Fixes: 9370f2d05a2a ("r8152: support request_firmware for RTL8153")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Grant Grundler <grundler@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/r8152.c

index d10b088..656fe90 100644 (file)
@@ -9786,6 +9786,7 @@ out1:
        cancel_delayed_work_sync(&tp->hw_phy_work);
        if (tp->rtl_ops.unload)
                tp->rtl_ops.unload(tp);
+       rtl8152_release_firmware(tp);
        usb_set_intfdata(intf, NULL);
 out:
        free_netdev(netdev);