n_tty: Convert no_space_left to space_left boolean
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Thu, 9 Mar 2023 08:20:28 +0000 (10:20 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Mar 2023 14:01:08 +0000 (15:01 +0100)
The no_space_left variable is only assigned with 0 and 1.

Change its type to boolean and move negation from its name into the
check.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20230309082035.14880-2-ilpo.jarvinen@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/n_tty.c

index c8f56c9..4fc5bd1 100644 (file)
@@ -625,7 +625,7 @@ static size_t __process_echoes(struct tty_struct *tty)
                c = echo_buf(ldata, tail);
                if (c == ECHO_OP_START) {
                        unsigned char op;
-                       int no_space_left = 0;
+                       bool space_left = true;
 
                        /*
                         * Since add_echo_byte() is called without holding
@@ -664,7 +664,7 @@ static size_t __process_echoes(struct tty_struct *tty)
                                num_bs = 8 - (num_chars & 7);
 
                                if (num_bs > space) {
-                                       no_space_left = 1;
+                                       space_left = false;
                                        break;
                                }
                                space -= num_bs;
@@ -690,7 +690,7 @@ static size_t __process_echoes(struct tty_struct *tty)
                        case ECHO_OP_START:
                                /* This is an escaped echo op start code */
                                if (!space) {
-                                       no_space_left = 1;
+                                       space_left = false;
                                        break;
                                }
                                tty_put_char(tty, ECHO_OP_START);
@@ -710,7 +710,7 @@ static size_t __process_echoes(struct tty_struct *tty)
                                 *
                                 */
                                if (space < 2) {
-                                       no_space_left = 1;
+                                       space_left = false;
                                        break;
                                }
                                tty_put_char(tty, '^');
@@ -720,7 +720,7 @@ static size_t __process_echoes(struct tty_struct *tty)
                                tail += 2;
                        }
 
-                       if (no_space_left)
+                       if (!space_left)
                                break;
                } else {
                        if (O_OPOST(tty)) {