Fix issues warned by compiler

Compiler warned about potential misuse of = operator in
src/client-async/logic/Logic.cpp file. It was intentional.
Additional brackets are used to supress compiler warning.

Compiler warned about unused returned value of flock() function
in src/common/lock/FileLock.cpp file. (void) casting is used
to stress that returned value should be ignored.

Change-Id: Ia986b5f66c58a7366eaca562a6325c1fc99ac033

diff --git a/src/client-async/logic/Logic.cpp b/src/client-async/logic/Logic.cpp
index 89373a7..10498e9 100644 (file)
--- a/src/client-async/logic/Logic.cpp
+++ b/src/client-async/logic/Logic.cpp
@@ -272,7 +272,7 @@ void Logic::processResponses(void) {
     CheckResponsePtr checkResponse;
     CancelResponsePtr cancelResponse;
     SimpleCheckResponsePtr simpleResponse;
-    while (response = m_socketClient.getResponse()) {
+    while ((response = m_socketClient.getResponse())) {
         checkResponse = std::dynamic_pointer_cast<CheckResponse>(response);
         if (checkResponse) {
             processCheckResponse(*checkResponse);

diff --git a/src/common/lock/FileLock.cpp b/src/common/lock/FileLock.cpp
index 98141f6..851ace7 100644 (file)
--- a/src/common/lock/FileLock.cpp
+++ b/src/common/lock/FileLock.cpp
@@ -82,7 +82,7 @@ void FileLock::lock(void) {
 
 void FileLock::unlock(void) {
     LOGI("Releasing file lock");
-    TEMP_FAILURE_RETRY(::flock(m_lockable.m_fd, LOCK_UN));
+    (void) TEMP_FAILURE_RETRY(::flock(m_lockable.m_fd, LOCK_UN));
 }
 
 } /* namespace Cynara */