regulator: cpcap-regulator: Remove declared and set, but never used variable 'ignore'
authorLee Jones <lee.jones@linaro.org>
Thu, 25 Jun 2020 16:36:11 +0000 (17:36 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 25 Jun 2020 19:11:15 +0000 (20:11 +0100)
It's okay to not check the return value that you're not conserned
about, however it is not okay to assign a variable and not check or
use the result.

Fixes W=1 warnings(s):

 drivers/regulator/cpcap-regulator.c:172:13: warning: variable ‘ignore’ set but not used [-Wunused-but-set-variable]
 172 | int error, ignore;
 | ^~~~~~
 drivers/regulator/cpcap-regulator.c: In function ‘cpcap_regulator_disable’:
 drivers/regulator/cpcap-regulator.c:196:13: warning: variable ‘ignore’ set but not used [-Wunused-but-set-variable]
 196 | int error, ignore;
 | ^~~~~~

Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20200625163614.4001403-8-lee.jones@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/cpcap-regulator.c

index 1464260..e6fa243 100644 (file)
@@ -169,7 +169,7 @@ enum cpcap_regulator_id {
 static int cpcap_regulator_enable(struct regulator_dev *rdev)
 {
        struct cpcap_regulator *regulator = rdev_get_drvdata(rdev);
-       int error, ignore;
+       int error;
 
        error = regulator_enable_regmap(rdev);
        if (error)
@@ -180,7 +180,7 @@ static int cpcap_regulator_enable(struct regulator_dev *rdev)
                                           regulator->assign_mask,
                                           regulator->assign_mask);
                if (error)
-                       ignore = regulator_disable_regmap(rdev);
+                       regulator_disable_regmap(rdev);
        }
 
        return error;
@@ -193,7 +193,7 @@ static int cpcap_regulator_enable(struct regulator_dev *rdev)
 static int cpcap_regulator_disable(struct regulator_dev *rdev)
 {
        struct cpcap_regulator *regulator = rdev_get_drvdata(rdev);
-       int error, ignore;
+       int error;
 
        if (rdev->desc->enable_val & CPCAP_REG_OFF_MODE_SEC) {
                error = regmap_update_bits(rdev->regmap, regulator->assign_reg,
@@ -204,9 +204,9 @@ static int cpcap_regulator_disable(struct regulator_dev *rdev)
 
        error = regulator_disable_regmap(rdev);
        if (error && (rdev->desc->enable_val & CPCAP_REG_OFF_MODE_SEC)) {
-               ignore = regmap_update_bits(rdev->regmap, regulator->assign_reg,
-                                           regulator->assign_mask,
-                                           regulator->assign_mask);
+               regmap_update_bits(rdev->regmap, regulator->assign_reg,
+                                  regulator->assign_mask,
+                                  regulator->assign_mask);
        }
 
        return error;