net: dsa: set name_assign_type to NET_NAME_ENUM for enumerated user ports
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Wed, 16 Nov 2022 10:52:04 +0000 (11:52 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 18 Nov 2022 03:40:08 +0000 (19:40 -0800)
When a user port does not have a label in device tree, and we thus
fall back to the eth%d scheme, the proper constant to use is
NET_NAME_ENUM. See also commit e9f656b7a214 ("net: ethernet: set
default assignment identifier to NET_NAME_ENUM"), which in turn quoted
commit 685343fc3ba6 ("net: add name_assign_type netdev attribute"):

    ... when the kernel has given the interface a name using global
    device enumeration based on order of discovery (ethX, wlanY, etc)
    ... are labelled NET_NAME_ENUM.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.faineli@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/dsa/slave.c

index 5405b73..24d8ad3 100644 (file)
@@ -2380,7 +2380,7 @@ int dsa_slave_create(struct dsa_port *port)
                assign_type = NET_NAME_PREDICTABLE;
        } else {
                name = "eth%d";
-               assign_type = NET_NAME_UNKNOWN;
+               assign_type = NET_NAME_ENUM;
        }
 
        slave_dev = alloc_netdev_mqs(sizeof(struct dsa_slave_priv), name,