validate:launcher: Factorize code to get a MediaDescriptor name for classname
authorThibault Saunier <tsaunier@gnome.org>
Fri, 12 Sep 2014 08:47:18 +0000 (10:47 +0200)
committerThibault Saunier <tsaunier@gnome.org>
Fri, 12 Sep 2014 09:26:48 +0000 (11:26 +0200)
Instead of copy/pasting that code badly

validate/tools/launcher/apps/gstvalidate.py
validate/tools/launcher/baseclasses.py

index 2324c06..daa43ed 100644 (file)
@@ -94,12 +94,9 @@ class GstValidateTranscodingTestsGenerator(GstValidateTestsGenerator):
                 continue
 
             for comb in self.test_manager.get_encoding_formats():
-                suffix = os.path.basename (mediainfo.media_descriptor.get_path())
-                suffix = suffix.replace (".media_info", "")
-                suffix = suffix.replace (".stream_info", "")
                 classname = "validate.%s.transcode.to_%s.%s" % (mediainfo.media_descriptor.get_protocol(),
                                                                 str(comb).replace(' ', '_'),
-                                                                suffix.replace('.', '_'))
+                                                                mediainfo.media_descriptor.get_clean_name())
                 self.add_test(GstValidateTranscodingTest(classname,
                                                          self.test_manager.options,
                                                          self.test_manager.reporter,
@@ -184,8 +181,7 @@ class GstValidatePlaybinTestsGenerator(GstValidatePipelineTestsGenerator):
 
                 fname = "%s.%s" % (self.get_fname(scenario,
                                    protocol),
-                                   os.path.basename(minfo.media_descriptor.get_path()).replace(".stream_info",
-                                       '').replace(".media_info", ''))
+                                   os.path.basename(minfo.media_descriptor.get_clean_name()))
                 self.debug("Adding: %s", fname)
 
                 if scenario.does_reverse_playback() and protocol == Protocols.HTTP:
index 395451c..4069039 100644 (file)
@@ -1219,6 +1219,11 @@ class GstValidateMediaDescriptor(MediaDescriptor):
 
         return n
 
+    def get_clean_name(self):
+        name = os.path.basename(self.get_path())
+        name = re.sub("\.stream_info|\.media_info", "", name)
+
+        return name.replace('.', "_")
 
 class MediaFormatCombination(object):
     _FORMATS = {"aac": "audio/mpeg,mpegversion=4",