ASoC: imx-hdmi: add put_device() after of_find_device_by_node()
authorYe Guojin <ye.guojin@zte.com.cn>
Wed, 10 Nov 2021 00:29:10 +0000 (00:29 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 10:04:57 +0000 (11:04 +0100)
[ Upstream commit f670b274f7f6f4b2722d7f08d0fddf606a727e92 ]

This was found by coccicheck:
./sound/soc/fsl/imx-hdmi.c,209,1-7,ERROR  missing put_device; call
of_find_device_by_node on line 119, but without a corresponding object
release within this function.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn>
Link: https://lore.kernel.org/r/20211110002910.134915-1-ye.guojin@zte.com.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/fsl/imx-hdmi.c

index 34a0dce..ef8d7a6 100644 (file)
@@ -145,6 +145,8 @@ static int imx_hdmi_probe(struct platform_device *pdev)
        data->dai.capture_only = false;
        data->dai.init = imx_hdmi_init;
 
+       put_device(&cpu_pdev->dev);
+
        if (of_node_name_eq(cpu_np, "sai")) {
                data->cpu_priv.sysclk_id[1] = FSL_SAI_CLK_MAST1;
                data->cpu_priv.sysclk_id[0] = FSL_SAI_CLK_MAST1;