[SystemSettings] Proper error handling
authorKamil Lysik <k.lysik@samsung.com>
Tue, 17 Mar 2015 14:40:44 +0000 (15:40 +0100)
committerRafal Galka <r.galka@samsung.com>
Fri, 20 Mar 2015 10:56:46 +0000 (19:56 +0900)
This module handled errors in invalid way.
Module should invoke util's getErrorObject.

This commit is required to Tizen TCT.

Change-Id: I73520b58d1800be74034ef3a1cbec8ae919d8678
Signed-off-by: Kamil Lysik <k.lysik@samsung.com>
src/systemsetting/systemsetting_api.js

index 50c0134bd1340eca8af0827766c9a71af96e8500..7cf25edcb56d6a3bc069f0da510a2171b995d96a 100644 (file)
@@ -35,10 +35,8 @@ SystemSettingManager.prototype.getProperty = function() {
     ]);
 
     var callback = function(result) {
-        if (result.status === 'error') {
-            if (!type_.isNullOrUndefined(args.errorCallback)) {
-                args.errorCallback(result.error);
-            }
+        if (native_.isFailure(result)) {
+            native_.callIfPossible(args.errorCallback, native_.getErrorObject(result));
         }
         else {
             args.successCallback(result.result.value);
@@ -61,10 +59,8 @@ SystemSettingManager.prototype.setProperty = function() {
     ]);
 
     var callback = function(result) {
-        if (result.status === 'error') {
-            if (!type_.isNullOrUndefined(args.errorCallback)) {
-                args.errorCallback(result.error);
-            }
+        if (native_.isFailure(result)) {
+            native_.callIfPossible(args.errorCallback, native_.getErrorObject(result));
         }
         else {
             args.successCallback();