xfs: use xfs_buf_item_relse in xfs_buf_item_done
authorChristoph Hellwig <hch@lst.de>
Tue, 1 Sep 2020 17:55:46 +0000 (10:55 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Wed, 16 Sep 2020 03:52:39 +0000 (20:52 -0700)
Reuse xfs_buf_item_relse instead of duplicating it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/xfs_buf_item.c

index 9245c62..5a7293d 100644 (file)
@@ -958,8 +958,6 @@ void
 xfs_buf_item_done(
        struct xfs_buf          *bp)
 {
-       struct xfs_buf_log_item *bip = bp->b_log_item;
-
        /*
         * If we are forcibly shutting down, this may well be off the AIL
         * already. That's because we simulate the log-committed callbacks to
@@ -969,8 +967,7 @@ xfs_buf_item_done(
         *
         * Either way, AIL is useless if we're forcing a shutdown.
         */
-       xfs_trans_ail_delete(&bip->bli_item, SHUTDOWN_CORRUPT_INCORE);
-       bp->b_log_item = NULL;
-       xfs_buf_item_free(bip);
-       xfs_buf_rele(bp);
+       xfs_trans_ail_delete(&bp->b_log_item->bli_item,
+                            SHUTDOWN_CORRUPT_INCORE);
+       xfs_buf_item_relse(bp);
 }