phy: qcom-qmp-combo: fix clock probing
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Sun, 20 Aug 2023 23:58:13 +0000 (02:58 +0300)
committerVinod Koul <vkoul@kernel.org>
Tue, 22 Aug 2023 14:05:13 +0000 (19:35 +0530)
During rebase of qcom-qmp-combo series a call to devm_clk_bulk_get_all()
got moved by git from qmp_combo_parse_dt_legacy() to
phy_dp_clks_register(). This doesn't have any serious effect, since the
clocks will be set in both legacy and non-legacy paths. However let's
move it back to place anyway, to prevent the driver from fetching clocks
twice.

Fixes: 28e265bf84a8 ("phy: qcom-qmp-combo: simplify clock handling")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20230820235813.562284-1-dmitry.baryshkov@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/qualcomm/phy-qcom-qmp-combo.c

index 9c3de41..cbb28af 100644 (file)
@@ -3067,12 +3067,6 @@ static int phy_dp_clks_register(struct qmp_combo *qmp, struct device_node *np)
        if (ret)
                return ret;
 
-       ret = devm_clk_bulk_get_all(qmp->dev, &qmp->clks);
-       if (ret < 0)
-               return ret;
-
-       qmp->num_clks = ret;
-
        return 0;
 }
 
@@ -3332,6 +3326,12 @@ static int qmp_combo_parse_dt_legacy(struct qmp_combo *qmp, struct device_node *
        if (ret)
                return ret;
 
+       ret = devm_clk_bulk_get_all(qmp->dev, &qmp->clks);
+       if (ret < 0)
+               return ret;
+
+       qmp->num_clks = ret;
+
        return 0;
 }