Previously (6ee4f99 bus: break reference cycle between bus and
messages) I committed the test code, but not the actual fix :)
test-bus-marshal \
test-bus-signature \
test-bus-chat \
+ test-bus-cleanup \
test-bus-server \
test-bus-match \
test-bus-kernel \
libsystemd-daemon-internal.la \
libsystemd-shared.la
+test_bus_cleanup_SOURCES = \
+ src/libsystemd/test-bus-cleanup.c
+
+test_bus_cleanup_LDADD = \
+ libsystemd-internal.la \
+ libsystemd-id128-internal.la \
+ libsystemd-daemon-internal.la \
+ libsystemd-shared.la
+
test_bus_server_SOURCES = \
src/libsystemd/test-bus-server.c
}
_public_ sd_bus *sd_bus_unref(sd_bus *bus) {
+ unsigned i;
if (!bus)
return NULL;
- if (REFCNT_DEC(bus->n_ref) <= 0)
- bus_free(bus);
+ i = REFCNT_DEC(bus->n_ref);
+ if (i != bus->rqueue_size + bus->wqueue_size)
+ return NULL;
+
+ for (i = 0; i < bus->rqueue_size; i++)
+ if (bus->rqueue[i]->n_ref > 1)
+ return NULL;
+
+ for (i = 0; i < bus->wqueue_size; i++)
+ if (bus->wqueue[i]->n_ref > 1)
+ return NULL;
+
+ /* we are the only holders on the messages */
+ bus_free(bus);
return NULL;
}