media: seco-cec: decrement HDMI device refcount
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 10 Apr 2019 09:13:33 +0000 (05:13 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 22 Apr 2019 17:14:24 +0000 (13:14 -0400)
The SECO CEC driver never decremented the HDMI device refcount.
CEC drivers only need the HDMI device pointer as a key in the
notifier list, it never accesses the device, so there is no
need to keep a reference.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/seco-cec/seco-cec.c

index a425a10..e5080d6 100644 (file)
@@ -536,6 +536,7 @@ static int secocec_cec_get_notifier(struct cec_notifier **notify)
                                return -EPROBE_DEFER;
 
                        *notify = cec_notifier_get_conn(d, m->conn);
+                       put_device(d);
 
                        return 0;
                }