Fix static analysis issues

Issues:
 - Uninitialized Variable
 - Resourced leak
 - Unused codes

Change-Id: I01fbf0161b8e9c13257348c0bf17d43dde0a3489
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>

diff --git a/src/lib/amd_app_property.c b/src/lib/amd_app_property.c
index 20c7960e2a373a02519d78fc53feb1d599f8de08..4dee92fb2264e6b04f57ac8659ac5a643bb6a4f5 100644 (file)
--- a/src/lib/amd_app_property.c
+++ b/src/lib/amd_app_property.c
@@ -1139,7 +1139,7 @@ static int __dispatch_app_unset_app_control_default_app(request_h req)
        int ret;
        app_property_h prop;
 
-       snprintf(appid, MAX_PACKAGE_STR_SIZE - 1, "%s",
+       snprintf(appid, sizeof(appid), "%s",
                        (const char *)_request_get_raw(req));
 
        ret = aul_svc_unset_defapp_for_uid(appid, _request_get_target_uid(req));

diff --git a/src/lib/amd_config.c b/src/lib/amd_config.c
index 242fb7ecfe63681957a08eb0cef9450880f774c2..f73ce4344176322d81fbf01f3554ea070d73e76d 100644 (file)
--- a/src/lib/amd_config.c
+++ b/src/lib/amd_config.c
@@ -243,5 +243,6 @@ int _config_init(void)
 void _config_fini(void)
 {
        _D("config fini");
+       free(__config.booting_status_key);
        free(__config.logger_path);
 }

diff --git a/src/lib/common/database.cc b/src/lib/common/database.cc
index d70f2b2200377c5bf2b47798b6f26cf00ae6ddd7..7c7adfd9dddedb4217eb17c99f1f7f1236fa6128 100644 (file)
--- a/src/lib/common/database.cc
+++ b/src/lib/common/database.cc
@@ -98,33 +98,6 @@ std::string Database::ColumnText(sqlite3_stmt* stmt, int index) {
   return {};
 }
 
-void Database::Attach(const std::string& db_path, const std::string& name) {
-  std::string query = "ATTACH DATABASE '" + db_path + "' AS "+ name;
-  int ret = sqlite3_exec(db_, query.c_str(), nullptr, nullptr, nullptr);
-  if (ret != SQLITE_OK) {
-    _E("sqlite3_exec() is failed. error(%s:%d)", sqlite3_errmsg(db_), ret);
-    THROW(-ret);
-  }
-}
-
-void Database::Detach(const std::string& name) {
-  std::string query = "DETACH DATABASE " + name;
-  int ret = sqlite3_exec(db_, query.c_str(), nullptr, nullptr, nullptr);
-  if (ret != SQLITE_OK) {
-    _E("sqlite3_exec() is failed. error(%s:%d)", sqlite3_errmsg(db_), ret);
-    THROW(-ret);
-  }
-}
-
-void Database::SetJournalMode(const std::string& mode) {
-  std::string query = "PRAGMA journal_mode=" + mode;
-  int ret = sqlite3_exec(db_, query.c_str(), nullptr, nullptr, nullptr);
-  if (ret != SQLITE_OK) {
-    _E("sqlite3_exec() is failed. error(%s:%d)", sqlite3_errmsg(db_), ret);
-    THROW(-ret);
-  }
-}
-
 bool Database::IntegrityCheck() {
   static const char query[] = "PRAGMA integrity_check";
   sqlite3_stmt* stmt;

diff --git a/src/lib/common/database.hh b/src/lib/common/database.hh
index fee00bf80719ea5a03abfae58752f9d378fddb7c..4579da71b8d730f3ef26b59dacbb851eb8742430 100644 (file)
--- a/src/lib/common/database.hh
+++ b/src/lib/common/database.hh
@@ -72,9 +72,6 @@ class Database {
   void Rollback();
   sqlite3* GetHandle();
   std::string ColumnText(sqlite3_stmt* stmt, int index);
-  void Attach(const std::string& db_path, const std::string& name);
-  void Detach(const std::string& name);
-  void SetJournalMode(const std::string& mode);
 
  private:
   static int BusyHandler(void* data, int count);

diff --git a/src/modules/rua/src/amd_rua_info.c b/src/modules/rua/src/amd_rua_info.c
index a85b7c45bd8b4c5da0ee6f28992bb4e36ff65016..49a91b19547ff7fa33ceac58b433ec7ce8a28f5c 100644 (file)
--- a/src/modules/rua/src/amd_rua_info.c
+++ b/src/modules/rua/src/amd_rua_info.c
@@ -549,7 +549,7 @@ static int __on_app_group_window_set(const char *msg, int arg1, int arg2,
 {
        int pid = arg1;
        int wid = arg2;
-       const char *instance_id = (const char *)instance_id;
+       const char *instance_id = (const char *)arg3;
        amd_app_status_h app_status;
        amd_comp_status_h comp_status;
        const char *leader_id;