crypto: s5p-sss - Pass error from clk_get and reduce verbosity on deferral
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 3 Sep 2020 18:04:00 +0000 (20:04 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 11 Sep 2020 04:39:17 +0000 (14:39 +1000)
Pass the error directly from devm_clk_get() to describe the real reason,
instead of fixed ENOENT.  Do not print error messages on deferred probe.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Kamil Konieczny <k.konieczny@samsung.com>
Acked-by: Kamil Konieczny <k.konieczny@samsung.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/s5p-sss.c

index ac27384..88a6c85 100644 (file)
@@ -2201,11 +2201,10 @@ static int s5p_aes_probe(struct platform_device *pdev)
        }
 
        pdata->clk = devm_clk_get(dev, variant->clk_names[0]);
-       if (IS_ERR(pdata->clk)) {
-               dev_err(dev, "failed to find secss clock %s\n",
-                       variant->clk_names[0]);
-               return -ENOENT;
-       }
+       if (IS_ERR(pdata->clk))
+               return dev_err_probe(dev, PTR_ERR(pdata->clk),
+                                    "failed to find secss clock %s\n",
+                                    variant->clk_names[0]);
 
        err = clk_prepare_enable(pdata->clk);
        if (err < 0) {
@@ -2217,9 +2216,9 @@ static int s5p_aes_probe(struct platform_device *pdev)
        if (variant->clk_names[1]) {
                pdata->pclk = devm_clk_get(dev, variant->clk_names[1]);
                if (IS_ERR(pdata->pclk)) {
-                       dev_err(dev, "failed to find clock %s\n",
-                               variant->clk_names[1]);
-                       err = -ENOENT;
+                       err = dev_err_probe(dev, PTR_ERR(pdata->pclk),
+                                           "failed to find clock %s\n",
+                                           variant->clk_names[1]);
                        goto err_clk;
                }