ASoC: SOF: ipc4-topology: Print queue IDs in error
authorRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Thu, 9 Feb 2023 14:21:22 +0000 (16:21 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 9 Feb 2023 14:31:16 +0000 (14:31 +0000)
Print the queue ID's during bind/unbind errors as well to make it easier
to see what failed exactly.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20230209142123.17193-2-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/ipc4-topology.c

index 43340c8..02ddc48 100644 (file)
@@ -1790,8 +1790,9 @@ static int sof_ipc4_route_setup(struct snd_sof_dev *sdev, struct snd_sof_route *
 
        ret = sof_ipc_tx_message(sdev->ipc, &msg, 0, NULL, 0);
        if (ret < 0) {
-               dev_err(sdev->dev, "%s: failed to bind modules %s -> %s\n",
-                       __func__, src_widget->widget->name, sink_widget->widget->name);
+               dev_err(sdev->dev, "failed to bind modules %s:%d -> %s:%d\n",
+                       src_widget->widget->name, sroute->src_queue_id,
+                       sink_widget->widget->name, sroute->dst_queue_id);
 
                sof_ipc4_put_queue_id(src_widget, sroute->src_queue_id,
                                      SOF_PIN_TYPE_SOURCE);
@@ -1839,8 +1840,9 @@ static int sof_ipc4_route_free(struct snd_sof_dev *sdev, struct snd_sof_route *s
 
        ret = sof_ipc_tx_message(sdev->ipc, &msg, 0, NULL, 0);
        if (ret < 0)
-               dev_err(sdev->dev, "failed to unbind modules %s -> %s\n",
-                       src_widget->widget->name, sink_widget->widget->name);
+               dev_err(sdev->dev, "failed to unbind modules %s:%d -> %s:%d\n",
+                       src_widget->widget->name, sroute->src_queue_id,
+                       sink_widget->widget->name, sroute->dst_queue_id);
 out:
        sof_ipc4_put_queue_id(sink_widget, sroute->dst_queue_id, SOF_PIN_TYPE_SINK);
        sof_ipc4_put_queue_id(src_widget, sroute->src_queue_id, SOF_PIN_TYPE_SOURCE);