projects
/
platform
/
upstream
/
llvm.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
d64a22a
)
[llvm][MachO] fix adding weak def syms
author
Cyndy Ishida
<cyndy_ishida@apple.com>
Tue, 3 Mar 2020 00:58:14 +0000
(16:58 -0800)
committer
Cyndy Ishida
<cyndy_ishida@apple.com>
Tue, 3 Mar 2020 01:00:24 +0000
(17:00 -0800)
the weak defined symbol flag was missing from the call site for adding
symbols which didn't cause issues because it invoked the default
parameter.
llvm/lib/TextAPI/MachO/TextStub.cpp
patch
|
blob
|
history
diff --git
a/llvm/lib/TextAPI/MachO/TextStub.cpp
b/llvm/lib/TextAPI/MachO/TextStub.cpp
index
cdfe7f4
..
5637639
100644
(file)
--- a/
llvm/lib/TextAPI/MachO/TextStub.cpp
+++ b/
llvm/lib/TextAPI/MachO/TextStub.cpp
@@
-959,7
+959,8
@@
template <> struct MappingTraits<const InterfaceFile *> {
for (auto &sym : CurrentSection.WeakSymbols)
File->addSymbol(SymbolKind::GlobalSymbol, sym,
- CurrentSection.Targets);
+ CurrentSection.Targets, SymbolFlags::WeakDefined);
+
for (auto &sym : CurrentSection.TlvSymbols)
File->addSymbol(SymbolKind::GlobalSymbol, sym,
CurrentSection.Targets,