[llvm][MachO] fix adding weak def syms
authorCyndy Ishida <cyndy_ishida@apple.com>
Tue, 3 Mar 2020 00:58:14 +0000 (16:58 -0800)
committerCyndy Ishida <cyndy_ishida@apple.com>
Tue, 3 Mar 2020 01:00:24 +0000 (17:00 -0800)
the weak defined symbol flag was missing from the call site for adding
symbols which didn't cause issues because it invoked the default
parameter.

llvm/lib/TextAPI/MachO/TextStub.cpp

index cdfe7f4..5637639 100644 (file)
@@ -959,7 +959,8 @@ template <> struct MappingTraits<const InterfaceFile *> {
 
           for (auto &sym : CurrentSection.WeakSymbols)
             File->addSymbol(SymbolKind::GlobalSymbol, sym,
-                            CurrentSection.Targets);
+                            CurrentSection.Targets, SymbolFlags::WeakDefined);
+
           for (auto &sym : CurrentSection.TlvSymbols)
             File->addSymbol(SymbolKind::GlobalSymbol, sym,
                             CurrentSection.Targets,