Thanks to Christian Kellner for pointing out these bugs (and submitting

2004-06-17  Jeffrey Stedfast  <fejj@ximian.com>

	Thanks to Christian Kellner for pointing out these bugs (and
	submitting the original patch for service_setv)

	* camel-service.c (service_setv): Don't use (tag &
	CAMEL_ARG_IGNORE) to determine if we should ignore this
	tag. CAMEL_ARG_IGNORE is not a bit flag.

	* providers/imap/camel-imap-store.c (imap_setv): Don't use (tag &
	CAMEL_ARG_IGNORE) to determine if we should ignore this
	tag. CAMEL_ARG_IGNORE is not a bit flag.

diff --git a/camel/ChangeLog b/camel/ChangeLog
index de5a663..6698923 100644 (file)
--- a/camel/ChangeLog
+++ b/camel/ChangeLog
@@ -1,8 +1,15 @@
 2004-06-17  Jeffrey Stedfast  <fejj@ximian.com>
 
-       * providers/imap/camel-imap-store.c (imap_setv): Only ignore if
-       (tag & CAMEL_ARG_TAG) == CAMEL_ARG_IGNORE, not if (tag &
-       CAMEL_ARG_IGNORE) is true.
+       Thanks to Christian Kellner for pointing out these bugs (and
+       submitting the original patch for service_setv)
+
+       * camel-service.c (service_setv): Don't use (tag &
+       CAMEL_ARG_IGNORE) to determine if we should ignore this
+       tag. CAMEL_ARG_IGNORE is not a bit flag.
+
+       * providers/imap/camel-imap-store.c (imap_setv): Don't use (tag &
+       CAMEL_ARG_IGNORE) to determine if we should ignore this
+       tag. CAMEL_ARG_IGNORE is not a bit flag.
 
 2004-06-16  Jeffrey Stedfast  <fejj@ximian.com>
 

diff --git a/camel/camel-service.c b/camel/camel-service.c
index bb43b60..229f0d2 100644 (file)
--- a/camel/camel-service.c
+++ b/camel/camel-service.c
@@ -161,10 +161,6 @@ service_setv (CamelObject *object, CamelException *ex, CamelArgV *args)
        for (i = 0; i < args->argc; i++) {
                tag = args->argv[i].tag;
                
-               /* make sure this arg wasn't already handled */
-               if (tag & CAMEL_ARG_IGNORE)
-                       continue;
-               
                /* make sure this is an arg we're supposed to handle */
                if ((tag & CAMEL_ARG_TAG) <= CAMEL_SERVICE_ARG_FIRST ||
                    (tag & CAMEL_ARG_TAG) >= CAMEL_SERVICE_ARG_FIRST + 100)