Add return value check. 68/109568/4
authorAnamika Singh <anamika.sd@samsung.com>
Tue, 10 Jan 2017 12:58:12 +0000 (18:28 +0530)
committerBoram Park <boram1288.park@samsung.com>
Thu, 12 Jan 2017 03:50:14 +0000 (12:50 +0900)
Change-Id: If2bebc87b5ba75c286bae6c7215055938d506c7b
Signed-off-by: Anamika Singh <anamika.sd@samsung.com>
Signed-off-by: Boram Park <boram1288.park@samsung.com>
src/tdm_display.c
src/tdm_helper.c

index 9cd7c4a8cd51fa5976f619e1e4a381aac521ea36..a8fa6942fe708e44e8dc164160346117d031f213 100644 (file)
@@ -1157,6 +1157,7 @@ _tdm_output_commit(tdm_output *output, int sync, tdm_output_commit_handler func,
                private_output->regist_commit_cb = 1;
                ret = func_output->output_set_commit_handler(private_output->output_backend,
                                tdm_output_cb_commit);
+               TDM_GOTO_IF_FAIL(ret == TDM_ERROR_NONE, commit_failed);
        }
 
        output_commit_handler = calloc(1, sizeof(tdm_private_output_commit_handler));
@@ -1376,6 +1377,7 @@ tdm_output_set_dpms(tdm_output *output, tdm_output_dpms dpms_value)
                        private_output->regist_dpms_cb = 1;
                        ret = func_output->output_set_dpms_handler(private_output->output_backend,
                                        tdm_output_cb_dpms, private_output);
+                       TDM_RETURN_VAL_IF_FAIL(ret == TDM_ERROR_NONE, ret);
                }
        }
 
index a72f3eb01f6e774f070c84c25243eee0937321db..87df71463b9c3ede16b484b8c98c6805ff6b3e29 100644 (file)
@@ -534,7 +534,12 @@ tdm_helper_get_fd(const char *env)
 
        TDM_INFO("%s: fd(%d) newfd(%d)", env, fd, newfd);
 
-       fcntl(newfd, F_SETFD, flags | FD_CLOEXEC);
+       ret = fcntl(newfd, F_SETFD, flags | FD_CLOEXEC);
+       if (ret == -1) {
+               TDM_ERR("fcntl failed: %m");
+               close(newfd);
+               return -1;
+       }
 
        return newfd;
 }