serial: ucc_uart: Use uart_circ_empty()
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Mon, 20 Mar 2023 13:50:08 +0000 (15:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Mar 2023 08:53:57 +0000 (10:53 +0200)
Use uart_circ_empty() rather than open coding it.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20230320135009.47170-1-ilpo.jarvinen@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/ucc_uart.c

index 6768408..404230c 100644 (file)
@@ -366,15 +366,14 @@ static int qe_uart_tx_pump(struct uart_qe_port *qe_port)
        /* Pick next descriptor and fill from buffer */
        bdp = qe_port->tx_cur;
 
-       while (!(ioread16be(&bdp->status) & BD_SC_READY) &&
-              (xmit->tail != xmit->head)) {
+       while (!(ioread16be(&bdp->status) & BD_SC_READY) && !uart_circ_empty(xmit)) {
                count = 0;
                p = qe2cpu_addr(be32_to_cpu(bdp->buf), qe_port);
                while (count < qe_port->tx_fifosize) {
                        *p++ = xmit->buf[xmit->tail];
                        uart_xmit_advance(port, 1);
                        count++;
-                       if (xmit->head == xmit->tail)
+                       if (uart_circ_empty(xmit))
                                break;
                }