habanalabs/gaudi: remove pcie_en strap toggle
authorIgor Grinberg <igrinberg@habana.ai>
Thu, 29 Oct 2020 12:06:54 +0000 (14:06 +0200)
committerOded Gabbay <ogabbay@kernel.org>
Mon, 30 Nov 2020 08:47:33 +0000 (10:47 +0200)
Since the very large grace period is over and this functionality
prevents us to implement the new reset sequence and apply security
settings, we need to remove the code toggling the PCIE_EN bit in the
straps register.
Remove it for good.

Signed-off-by: Igor Grinberg <igrinberg@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/misc/habanalabs/gaudi/gaudi.c

index 18c7da9..770cd1b 100644 (file)
@@ -3859,7 +3859,7 @@ disable_queues:
 static void gaudi_hw_fini(struct hl_device *hdev, bool hard_reset)
 {
        struct gaudi_device *gaudi = hdev->asic_specific;
-       u32 status, reset_timeout_ms, cpu_timeout_ms, boot_strap = 0;
+       u32 status, reset_timeout_ms, cpu_timeout_ms;
 
        if (!hard_reset) {
                dev_err(hdev->dev, "GAUDI doesn't support soft-reset\n");
@@ -3891,16 +3891,6 @@ static void gaudi_hw_fini(struct hl_device *hdev, bool hard_reset)
        /* Tell ASIC not to re-initialize PCIe */
        WREG32(mmPREBOOT_PCIE_EN, LKD_HARD_RESET_MAGIC);
 
-       boot_strap = RREG32(mmPSOC_GLOBAL_CONF_BOOT_STRAP_PINS);
-
-       /* H/W bug WA:
-        * rdata[31:0] = strap_read_val;
-        * wdata[31:0] = rdata[30:21],1'b0,rdata[20:0]
-        */
-       boot_strap = (((boot_strap & 0x7FE00000) << 1) |
-                       (boot_strap & 0x001FFFFF));
-       WREG32(mmPSOC_GLOBAL_CONF_BOOT_STRAP_PINS, boot_strap & ~0x2);
-
        /* Restart BTL/BLR upon hard-reset */
        if (hdev->asic_prop.fw_security_disabled)
                WREG32(mmPSOC_GLOBAL_CONF_BOOT_SEQ_RE_START, 1);
@@ -3923,8 +3913,6 @@ static void gaudi_hw_fini(struct hl_device *hdev, bool hard_reset)
                        "Timeout while waiting for device to reset 0x%x\n",
                        status);
 
-       WREG32(mmPSOC_GLOBAL_CONF_BOOT_STRAP_PINS, boot_strap);
-
        if (gaudi) {
                gaudi->hw_cap_initialized &= ~(HW_CAP_CPU | HW_CAP_CPU_Q |
                                HW_CAP_HBM | HW_CAP_PCI_DMA |