Add nullable annotations to System.Diagnostics.Debug ref (dotnet/corefx#38427)
authorSantiago Fernandez Madero <safern@microsoft.com>
Thu, 20 Jun 2019 01:25:48 +0000 (18:25 -0700)
committerGitHub <noreply@github.com>
Thu, 20 Jun 2019 01:25:48 +0000 (18:25 -0700)
Commit migrated from https://github.com/dotnet/corefx/commit/8f98894f55cafc2f51adf40b380fcd194c596bb8

src/libraries/System.Diagnostics.Debug/ref/System.Diagnostics.Debug.cs
src/libraries/System.Diagnostics.Debug/ref/System.Diagnostics.Debug.csproj

index 6816a5d..bc63cb0 100644 (file)
@@ -13,72 +13,74 @@ namespace System.Diagnostics
         public static int IndentLevel { get { throw null; } set { } }
         public static int IndentSize { get { throw null; } set { } }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void Assert(bool condition) { }
+        public static void Assert([System.Diagnostics.CodeAnalysis.DoesNotReturnIfAttribute(false)] bool condition) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void Assert(bool condition, string message) { }
+        public static void Assert([System.Diagnostics.CodeAnalysis.DoesNotReturnIfAttribute(false)] bool condition, string? message) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void Assert(bool condition, string message, string detailMessage) { }
+        public static void Assert([System.Diagnostics.CodeAnalysis.DoesNotReturnIfAttribute(false)] bool condition, string? message, string? detailMessage) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void Assert(bool condition, string message, string detailMessageFormat, params object[] args) { }
+        public static void Assert([System.Diagnostics.CodeAnalysis.DoesNotReturnIfAttribute(false)] bool condition, string? message, string detailMessageFormat, params object?[] args) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
         public static void Close() { }
+        [System.Diagnostics.CodeAnalysis.DoesNotReturnAttribute]
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void Fail(string message) { }
+        public static void Fail(string? message) { }
+        [System.Diagnostics.CodeAnalysis.DoesNotReturnAttribute]
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void Fail(string message, string detailMessage) { }
+        public static void Fail(string? message, string? detailMessage) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
         public static void Flush() { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
         public static void Indent() { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void Print(string message) { }
+        public static void Print(string? message) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void Print(string format, params object[] args) { }
+        public static void Print(string format, params object?[] args) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
         public static void Unindent() { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void Write(object value) { }
+        public static void Write(object? value) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void Write(object value, string category) { }
+        public static void Write(object? value, string? category) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void Write(string message) { }
+        public static void Write(string? message) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void Write(string message, string category) { }
+        public static void Write(string? message, string? category) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void WriteIf(bool condition, object value) { }
+        public static void WriteIf(bool condition, object? value) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void WriteIf(bool condition, object value, string category) { }
+        public static void WriteIf(bool condition, object? value, string? category) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void WriteIf(bool condition, string message) { }
+        public static void WriteIf(bool condition, string? message) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void WriteIf(bool condition, string message, string category) { }
+        public static void WriteIf(bool condition, string? message, string? category) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void WriteLine(object value) { }
+        public static void WriteLine(object? value) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void WriteLine(object value, string category) { }
+        public static void WriteLine(object? value, string? category) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void WriteLine(string message) { }
+        public static void WriteLine(string? message) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void WriteLine(string format, params object[] args) { }
+        public static void WriteLine(string format, params object?[] args) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void WriteLine(string message, string category) { }
+        public static void WriteLine(string? message, string? category) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void WriteLineIf(bool condition, object value) { }
+        public static void WriteLineIf(bool condition, object? value) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void WriteLineIf(bool condition, object value, string category) { }
+        public static void WriteLineIf(bool condition, object? value, string? category) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void WriteLineIf(bool condition, string message) { }
+        public static void WriteLineIf(bool condition, string? message) { }
         [System.Diagnostics.ConditionalAttribute("DEBUG")]
-        public static void WriteLineIf(bool condition, string message, string category) { }
+        public static void WriteLineIf(bool condition, string? message, string? category) { }
     }
     public static partial class Debugger
     {
-        public static readonly string DefaultCategory;
+        public static readonly string? DefaultCategory;
         public static bool IsAttached { get { throw null; } }
         public static void Break() { }
         public static bool IsLogging() { throw null; }
         public static bool Launch() { throw null; }
-        public static void Log(int level, string category, string message) { }
+        public static void Log(int level, string? category, string? message) { }
         public static void NotifyOfCrossThreadDependency() { }
     }
     [System.AttributeUsageAttribute(System.AttributeTargets.Field | System.AttributeTargets.Property, AllowMultiple=false)]
@@ -96,11 +98,11 @@ namespace System.Diagnostics
     [System.AttributeUsageAttribute(System.AttributeTargets.Assembly | System.AttributeTargets.Class | System.AttributeTargets.Delegate | System.AttributeTargets.Enum | System.AttributeTargets.Field | System.AttributeTargets.Property | System.AttributeTargets.Struct, AllowMultiple=true)]
     public sealed partial class DebuggerDisplayAttribute : System.Attribute
     {
-        public DebuggerDisplayAttribute(string value) { }
-        public string Name { get { throw null; } set { } }
-        public System.Type Target { get { throw null; } set { } }
-        public string TargetTypeName { get { throw null; } set { } }
-        public string Type { get { throw null; } set { } }
+        public DebuggerDisplayAttribute(string? value) { }
+        public string? Name { get { throw null; } set { } }
+        public System.Type? Target { get { throw null; } set { } }
+        public string? TargetTypeName { get { throw null; } set { } }
+        public string? Type { get { throw null; } set { } }
         public string Value { get { throw null; } }
     }
     [System.AttributeUsageAttribute(System.AttributeTargets.Constructor | System.AttributeTargets.Method | System.AttributeTargets.Property, Inherited=false)]
@@ -129,22 +131,22 @@ namespace System.Diagnostics
         public DebuggerTypeProxyAttribute(string typeName) { }
         public DebuggerTypeProxyAttribute(System.Type type) { }
         public string ProxyTypeName { get { throw null; } }
-        public System.Type Target { get { throw null; } set { } }
-        public string TargetTypeName { get { throw null; } set { } }
+        public System.Type? Target { get { throw null; } set { } }
+        public string? TargetTypeName { get { throw null; } set { } }
     }
     [System.AttributeUsageAttribute(System.AttributeTargets.Assembly | System.AttributeTargets.Class | System.AttributeTargets.Struct, AllowMultiple=true)]
     public sealed partial class DebuggerVisualizerAttribute : System.Attribute
     {
         public DebuggerVisualizerAttribute(string visualizerTypeName) { }
-        public DebuggerVisualizerAttribute(string visualizerTypeName, string visualizerObjectSourceTypeName) { }
+        public DebuggerVisualizerAttribute(string visualizerTypeName, string? visualizerObjectSourceTypeName) { }
         public DebuggerVisualizerAttribute(string visualizerTypeName, System.Type visualizerObjectSource) { }
         public DebuggerVisualizerAttribute(System.Type visualizer) { }
-        public DebuggerVisualizerAttribute(System.Type visualizer, string visualizerObjectSourceTypeName) { }
+        public DebuggerVisualizerAttribute(System.Type visualizer, string? visualizerObjectSourceTypeName) { }
         public DebuggerVisualizerAttribute(System.Type visualizer, System.Type visualizerObjectSource) { }
-        public string Description { get { throw null; } set { } }
-        public System.Type Target { get { throw null; } set { } }
-        public string TargetTypeName { get { throw null; } set { } }
-        public string VisualizerObjectSourceTypeName { get { throw null; } }
+        public string? Description { get { throw null; } set { } }
+        public System.Type? Target { get { throw null; } set { } }
+        public string? TargetTypeName { get { throw null; } set { } }
+        public string? VisualizerObjectSourceTypeName { get { throw null; } }
         public string VisualizerTypeName { get { throw null; } }
     }
 }
index b68bfc4..e36cd70 100644 (file)
@@ -2,6 +2,7 @@
   <PropertyGroup>
     <ProjectGuid>{2CBC7A79-EDF5-4552-B25D-8E32E367571E}</ProjectGuid>
     <Configurations>netcoreapp-Debug;netcoreapp-Release;uap-Debug;uap-Release</Configurations>
+    <Nullable>enable</Nullable>
   </PropertyGroup>
   <ItemGroup>
     <Compile Include="System.Diagnostics.Debug.cs" />