[turbofan] Fix typo in IrOpcode::Mnemonic.

TEST=unittests
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/843043002

Cr-Commit-Position: refs/heads/master@{#26014}

diff --git a/src/compiler/opcodes.cc b/src/compiler/opcodes.cc
index 044395c..1c94c19 100644 (file)
--- a/src/compiler/opcodes.cc
+++ b/src/compiler/opcodes.cc
@@ -25,7 +25,7 @@ char const* const kMnemonics[] = {
 
 // static
 char const* IrOpcode::Mnemonic(Value value) {
-  size_t const n = std::max<size_t>(value, arraysize(kMnemonics) - 1);
+  size_t const n = std::min<size_t>(value, arraysize(kMnemonics) - 1);
   return kMnemonics[n];
 }
 

diff --git a/test/unittests/compiler/opcodes-unittest.cc b/test/unittests/compiler/opcodes-unittest.cc
new file mode 100644 (file)
index 0000000..3a97178
--- /dev/null
+++ b/test/unittests/compiler/opcodes-unittest.cc
@@ -0,0 +1,25 @@
+// Copyright 2015 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <cstring>
+
+#include "src/compiler/opcodes.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace v8 {
+namespace internal {
+namespace compiler {
+
+TEST(IrOpcodeTest, Mnemonic) {
+  EXPECT_STREQ("UnknownOpcode",
+               IrOpcode::Mnemonic(static_cast<IrOpcode::Value>(123456789)));
+#define OPCODE(Opcode) \
+  EXPECT_STREQ(#Opcode, IrOpcode::Mnemonic(IrOpcode::k##Opcode));
+  ALL_OP_LIST(OPCODE)
+#undef OPCODE
+}
+
+}  // namespace compiler
+}  // namespace internal
+}  // namespace v8

diff --git a/test/unittests/unittests.gyp b/test/unittests/unittests.gyp
index 2ead44f..fe4a127 100644 (file)
--- a/test/unittests/unittests.gyp
+++ b/test/unittests/unittests.gyp
@@ -60,6 +60,7 @@
         'compiler/node-matchers-unittest.cc',
         'compiler/node-test-utils.cc',
         'compiler/node-test-utils.h',
+        'compiler/opcodes-unittest.cc',
         'compiler/register-allocator-unittest.cc',
         'compiler/select-lowering-unittest.cc',
         'compiler/simplified-operator-reducer-unittest.cc',