Fix NULL dereference defect 23/96223/1 accepted/tizen/3.0/common/20161114.082555 accepted/tizen/3.0/ivi/20161110.020332 accepted/tizen/3.0/mobile/20161110.020239 accepted/tizen/3.0/tv/20161110.020254 accepted/tizen/3.0/wearable/20161110.020314 submit/tizen_3.0/20161108.101813 submit/tizen_3.0_common/20161110.084657
authorHyunho Kang <hhstark.kang@samsung.com>
Tue, 8 Nov 2016 07:36:55 +0000 (16:36 +0900)
committerHyunho Kang <hhstark.kang@samsung.com>
Tue, 8 Nov 2016 07:38:51 +0000 (16:38 +0900)
Change-Id: I58e5ba3102f62e6d006a718235eaca0c42bebb27
Signed-off-by: Hyunho Kang <hhstark.kang@samsung.com>
src/alarm-lib-stub.c

index 4b9bc3f..cd7fd82 100644 (file)
@@ -56,6 +56,11 @@ bool _send_alarm_create_noti(alarm_context_t context, alarm_info_t *alarm_info,
        int datalen = 0;
 
        noti_gv = notification_ipc_make_gvariant_from_noti(noti, true);
+       if (!noti_gv) {
+               if (error_code)
+                       *error_code = ERR_ALARM_SYSTEM_FAIL;
+               return false;
+       }
 
        datalen = g_variant_get_size(noti_gv);
        if (datalen < 0)
@@ -65,13 +70,6 @@ bool _send_alarm_create_noti(alarm_context_t context, alarm_info_t *alarm_info,
        if (!data)
                return false;
 
-       if (!noti_gv) {
-               if (error_code)
-                       *error_code = ERR_ALARM_SYSTEM_FAIL;
-               free(data);
-               return false;
-       }
-
        g_variant_store(noti_gv, data);
        noti_data = g_base64_encode((guchar *)data, datalen);