s390/qeth: don't raise NETDEV_REBOOT event from L3 offline path
authorJulian Wiedmann <jwi@linux.ibm.com>
Wed, 18 Dec 2019 16:34:47 +0000 (17:34 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 18 Dec 2019 20:34:56 +0000 (12:34 -0800)
This is a leftover from back when a recovery action didn't go through
dev_close(), and was meant to shoot down all remaining af_iucv sockets
on the interface.

Now that the offline path always calls dev_close(), the
NETDEV_GOING_DOWN event from __dev_close_many() is sufficient and this
hack can be removed.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_l3_main.c

index bd2273f..8bd3fc7 100644 (file)
@@ -2288,12 +2288,6 @@ static int __qeth_l3_set_offline(struct ccwgroup_device *cgdev,
        rtnl_unlock();
 
        qeth_l3_stop_card(card);
-       if (card->options.cq == QETH_CQ_ENABLED) {
-               rtnl_lock();
-               call_netdevice_notifiers(NETDEV_REBOOT, card->dev);
-               rtnl_unlock();
-       }
-
        rc  = qeth_stop_channel(&card->data);
        rc2 = qeth_stop_channel(&card->write);
        rc3 = qeth_stop_channel(&card->read);