libaurum: fix potentional errors reported from svace/coverity
authorWonki Kim <wonki_.kim@samsung.com>
Fri, 14 Aug 2020 05:46:53 +0000 (14:46 +0900)
committerJongmin Lee <jm105.lee@samsung.com>
Thu, 27 Aug 2020 05:00:13 +0000 (14:00 +0900)
Change-Id: I9f433d4dba192ff3197cb0c2a538a870d69279ad

libaurum/src/Impl/MockDeviceImpl.cc
tests/ua_test.cpp

index cf56af248436ca5ad091cdb644b14d0684ec4d2e..3fdf45b474ef91ff6d62504ed38752d1ee64eed9 100644 (file)
@@ -12,6 +12,7 @@
 #include <stdio.h>
 
 MockDeviceImpl::MockDeviceImpl()
+:tStart{}, isTimerStarted{false}, mTouchSeq{}
 {
     printf("mockdevice ctor\n");printf("%s:%d / %s\n",__FILE__, __LINE__, __PRETTY_FUNCTION__);
 }
index 30fde1af3039d94197f7816ed69e414174fcb180..ad422cf7df1ccbf85d59bc68b337ba1acd3b9ca9 100644 (file)
@@ -71,26 +71,38 @@ TEST_F(UaTest, FindElement)
     auto watcher = AccessibleWatcher::getInstance();
 
     MockAccessibleWatcher *mockWatcher = dynamic_cast<MockAccessibleWatcher*>(const_cast<AccessibleWatcher*>(watcher));
+    ASSERT_NE(mockWatcher, nullptr);
 
     std::shared_ptr<MockAccessibleNode> appNode = std::make_shared<MockAccessibleNode>(nullptr, "text", "pkg", "application", "res","type","style", Rect<int>{0,0,100,200}, 0, 0);
+    ASSERT_NE(appNode, nullptr);
     std::shared_ptr<MockAccessibleApplication> app = std::make_shared<MockAccessibleApplication>(appNode);
+    ASSERT_NE(app, nullptr);
     mockWatcher->addApplication(app);
 
     std::shared_ptr<MockAccessibleNode> winNode = std::make_shared<MockAccessibleNode>(nullptr, "text", "pkg", "window", "res","type","style", Rect<int>{0,0,100,200}, 0, 0);
+    ASSERT_NE(winNode, nullptr);
+
     std::shared_ptr<MockAccessibleWindow> win = std::make_shared<MockAccessibleWindow>(app, winNode);
+    ASSERT_NE(win, nullptr);
+
     winNode->setFeatureProperty(8);
     winNode->setFeatureProperty(9);
     winNode->setFeatureProperty(10);
     app->addWindow(win);
 
-    std::shared_ptr<MockAccessibleNode> node = std::make_shared<MockAccessibleNode>(nullptr, "test", "pkg", "ahahah", "res","type","style", Rect<int>{0,0,100,200}, 0, 0);
+    std::shared_ptr<MockAccessibleNode> node = std::make_shared<MockAccessibleNode>(nullptr, "test", "pkg", "TeSt1234!@#$", "res","type","style", Rect<int>{0,0,100,200}, 0, 0);
+    ASSERT_NE(node, nullptr);
+    winNode->addChild(node);
+
+    node = std::make_shared<MockAccessibleNode>(nullptr, "test", "pkg", "TeSt1234!@#$", "res","type","style", Rect<int>{0,0,100,200}, 0, 0);
+    ASSERT_NE(node, nullptr);
     winNode->addChild(node);
 
     std::shared_ptr<UiSelector> sel = Sel::text("test");
     auto result = UiDevice::getInstance()->findObjects(sel);
     std::for_each(result.begin(), result.end(), [](auto obj){
-        ASSERT_EQ(obj->getRole(), "ahahah");
+        ASSERT_EQ(obj->getRole(), "TeSt1234!@#$");
     });
 
-    ASSERT_EQ(nullptr, nullptr);
+    ASSERT_EQ(result.size(), 2);
 }
\ No newline at end of file