sctp: remove unnecessary NULL check in sctp_ulpq_tail_event()
authorAlexey Kodanev <aleksei.kodanev@bell-sw.com>
Wed, 19 Oct 2022 18:07:34 +0000 (21:07 +0300)
committerJakub Kicinski <kuba@kernel.org>
Fri, 21 Oct 2022 04:43:10 +0000 (21:43 -0700)
After commit 013b96ec6461 ("sctp: Pass sk_buff_head explicitly to
sctp_ulpq_tail_event().") there is one more unneeded check of
skb_list for NULL.

Detected using the static analysis tool - Svace.
Signed-off-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
Reviewed-by: Xin Long <lucien.xin@gmail.com>
Link: https://lore.kernel.org/r/20221019180735.161388-2-aleksei.kodanev@bell-sw.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sctp/ulpqueue.c

index 24960dc..b05daaf 100644 (file)
@@ -256,10 +256,7 @@ int sctp_ulpq_tail_event(struct sctp_ulpq *ulpq, struct sk_buff_head *skb_list)
        return 1;
 
 out_free:
-       if (skb_list)
-               sctp_queue_purge_ulpevents(skb_list);
-       else
-               sctp_ulpevent_free(event);
+       sctp_queue_purge_ulpevents(skb_list);
 
        return 0;
 }