drbd: Remove redundant and wrong test for NULL simplification in conn_connect()
authorPhilipp Reisner <philipp.reisner@linbit.com>
Thu, 26 Jul 2012 12:12:59 +0000 (14:12 +0200)
committerPhilipp Reisner <philipp.reisner@linbit.com>
Fri, 9 Nov 2012 13:05:45 +0000 (14:05 +0100)
Since the drbd_socket_okay() function itself tests if the the
socket is NULL, the explicit test "if (sock.socket && &msock.socket)"
was redundent.
Apart from that the address opperator ('&') before msock.socket rendered
the test pointless.

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
drivers/block/drbd/drbd_receiver.c

index a6f0b29..855cadf 100644 (file)
@@ -985,13 +985,9 @@ retry:
                                goto out_release_sockets;
                }
 
-               if (sock.socket && &msock.socket) {
-                       ok = drbd_socket_okay(&sock.socket);
-                       ok = drbd_socket_okay(&msock.socket) && ok;
-                       if (ok)
-                               break;
-               }
-       } while (1);
+               ok = drbd_socket_okay(&sock.socket);
+               ok = drbd_socket_okay(&msock.socket) && ok;
+       } while (!ok);
 
        if (ad.s_listen)
                sock_release(ad.s_listen);