HID: i2c-hid: fix inverted return value from i2c_hid_command()
authorJiri Kosina <jkosina@suse.cz>
Thu, 19 Apr 2018 07:25:15 +0000 (09:25 +0200)
committerJiri Kosina <jkosina@suse.cz>
Thu, 19 Apr 2018 07:25:15 +0000 (09:25 +0200)
i2c_hid_command() returns non-zero in error cases (the actual
errno). Error handling in for I2C_HID_QUIRK_RESEND_REPORT_DESCR
case in i2c_hid_resume() had the check inverted; fix that.

Fixes: 3e83eda467 ("HID: i2c-hid: Fix resume issue on Raydium touchscreen device")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/i2c-hid/i2c-hid.c

index 615a91a..9633286 100644 (file)
@@ -1229,7 +1229,7 @@ static int i2c_hid_resume(struct device *dev)
         */
        if (ihid->quirks & I2C_HID_QUIRK_RESEND_REPORT_DESCR) {
                ret = i2c_hid_command(client, &hid_report_descr_cmd, NULL, 0);
-               if (!ret)
+               if (ret)
                        return ret;
        }