watchdog: pcwd_usb: Avoid GFP_ATOMIC where it is not needed
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 9 Aug 2020 07:19:12 +0000 (09:19 +0200)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Wed, 14 Oct 2020 13:02:22 +0000 (15:02 +0200)
There is no need to use GFP_ATOMIC here. It is a probe function, no
spinlock is taken and GFP_KERNEL is used just before and just after this
'usb_alloc_coherent()' call.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20200809071912.742836-1-christophe.jaillet@wanadoo.fr
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/pcwd_usb.c

index 41a928e..1bdaf17 100644 (file)
@@ -656,7 +656,7 @@ static int usb_pcwd_probe(struct usb_interface *interface,
 
        /* set up the memory buffer's */
        usb_pcwd->intr_buffer = usb_alloc_coherent(udev, usb_pcwd->intr_size,
-                                       GFP_ATOMIC, &usb_pcwd->intr_dma);
+                                       GFP_KERNEL, &usb_pcwd->intr_dma);
        if (!usb_pcwd->intr_buffer) {
                pr_err("Out of memory\n");
                goto error;