Remove APIs associated with not used fields 25/175025/1
authoryeji01.kim <yeji01.kim@samsung.com>
Fri, 6 Apr 2018 04:52:08 +0000 (13:52 +0900)
committeryeji01.kim <yeji01.kim@samsung.com>
Fri, 6 Apr 2018 05:10:16 +0000 (14:10 +0900)
- Removed fields : object effective user id, object effective group id
- Removed API : audit_system_log_get_object_effective_owner

Change-Id: I36923a9ae0da29bda0471d4bbbe80bf407257753
Signed-off-by: yeji01.kim <yeji01.kim@samsung.com>
common/audit/audit-system-log.h
lib/audit-trail/system-log.cpp
lib/audit-trail/system-log.h
rmi/log-management.h
tools/cli/audit-trail-admin-cli.cpp

index 28022f4ce99219cb4bf838204f5d18bf02b55b41..d10105f3e8fedb464ff00878d7db971e38a5677d 100644 (file)
@@ -44,8 +44,8 @@ struct AuditSystemLog final {
 
        struct {
                int type = NoObject;
-               uid_t uid = UINT_MAX, euid = UINT_MAX;
-               gid_t gid = UINT_MAX, egid = UINT_MAX;
+               uid_t uid = UINT_MAX;
+               gid_t gid = UINT_MAX;
                mode_t mode = UINT_MAX;
                std::string label;
                std::string name;
index 557b002ef97f3331ba6137ad564f3fb7020e4bad..af213c3f325d37ef63fb45a03d8610ef38cfcc06 100644 (file)
@@ -151,21 +151,6 @@ int audit_system_log_get_object_owner(audit_system_log_h handle,
        return AUDIT_TRAIL_ERROR_NONE;
 }
 
-int audit_system_log_get_object_effective_owner(audit_system_log_h handle,
-                                                                                               uid_t *euid, gid_t *egid)
-
-{
-       RET_ON_FAILURE(handle, AUDIT_TRAIL_ERROR_INVALID_PARAMETER);
-       RET_ON_FAILURE(euid, AUDIT_TRAIL_ERROR_INVALID_PARAMETER);
-       RET_ON_FAILURE(egid, AUDIT_TRAIL_ERROR_INVALID_PARAMETER);
-
-       const auto &log = GetSystemLog(handle).log;
-       *euid = log.object.euid;
-       *egid = log.object.egid;
-
-       return AUDIT_TRAIL_ERROR_NONE;
-}
-
 int audit_system_log_get_object_permission(audit_system_log_h handle, mode_t *mode)
 {
        RET_ON_FAILURE(handle, AUDIT_TRAIL_ERROR_INVALID_PARAMETER);
index 70a2e6d9ec57fc708662f238af104a33644ff72c..5459ba62daae33b87c51e4497ef254197c6c66bc 100644 (file)
@@ -174,22 +174,6 @@ AUDIT_TRAIL_API int audit_system_log_get_object_type(audit_system_log_h handle,
 AUDIT_TRAIL_API int audit_system_log_get_object_owner(audit_system_log_h handle,
                                                                                uid_t *uid, gid_t *gid);
 
-/**
- * @brief       Get the object effective owner's user and group ID from the system audit log
- * @details     This API can be used to get the object effective owner's user ID and group ID in
- *              each system audit logs.
- * @since_tizen 5.0
- * @param[in]   handle The system audit log handle
- * @param[out]  euid The object effective user ID
- * @param[out]  egid The object effective group ID
- * @return      #AUDIT_TRAIL_ERROR_NONE on success, otherwise a negative value
- * @retval      #AUDIT_TRAIL_ERROR_NONE Successful
- * @retval      #AUDIT_TRAIL_ERROR_TIMED_OUT Time out
- * @retval      #AUDIT_TRAIL_ERROR_INVALID_PARAMETER Invalid parameter
- */
-AUDIT_TRAIL_API int audit_system_log_get_object_effective_owner(audit_system_log_h handle,
-                                                                                                       uid_t *euid, gid_t *egid);
-
 /**
  * @brief       Get the object permission from the system audit log
  * @details     This API can be used to get the object effective owner's user ID and group ID in
index 93c7c88b7852c6a844795d40a85213d9eabe253c..07d906f18f713d847d56dd76eb7a1e4d52d5fc60 100644 (file)
@@ -31,8 +31,7 @@ struct SystemLog {
                                log.subject.uid, log.subject.euid,
                                log.subject.gid, log.subject.egid,
                                log.subject.label, log.subject.name, log.subject.pid,
-                               log.object.type, log.object.uid, log.object.euid,
-                               log.object.gid, log.object.egid,
+                               log.object.type, log.object.uid, log.object.gid,
                                log.object.mode, log.object.label,
                                log.object.name, log.object.socketAddr,
                                log.object.pid, log.object.inode,
index e8c8709a832f3668a2cdb9979048fe3730ba9e20..ea89ec2943902d4e88f613dea64457a54509ccf9 100644 (file)
@@ -155,8 +155,8 @@ std::string printSystemLog(audit_system_log_h log)
        str << "},object={";
        {
                int obj_type, sock_family;
-               uid_t obj_uid, obj_euid;
-               gid_t obj_gid, obj_egid;
+               uid_t obj_uid;
+               gid_t obj_gid;
                mode_t obj_mode;
                char *obj_label, *obj_name;
                pid_t obj_pid;
@@ -168,7 +168,6 @@ std::string printSystemLog(audit_system_log_h log)
                audit_system_log_get_object_name(log, &obj_name);
                audit_system_log_get_object_smack_label(log, &obj_label);
                audit_system_log_get_object_owner(log, &obj_uid, &obj_gid);
-               audit_system_log_get_object_effective_owner(log, &obj_euid, &obj_egid);
                audit_system_log_get_object_pid(log, &obj_pid);
                audit_system_log_get_object_permission(log, &obj_mode);
                audit_system_log_get_object_inode(log, &obj_inode);