scsi: ufs: Remove unnecessary devm_kfree()
authorBean Huo <beanhuo@micron.com>
Tue, 12 Jan 2021 09:21:28 +0000 (10:21 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 13 Jan 2021 05:30:04 +0000 (00:30 -0500)
The memory allocated with devm_kzalloc() is freed automatically no need to
explicitly call devm_kfree(). Delete it and save some instruction cycles.

Link: https://lore.kernel.org/r/20210112092128.19295-1-huobean@gmail.com
Reviewed-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Bean Huo <beanhuo@micron.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufshcd-crypto.c

index 07310b1..ec80ec8 100644 (file)
@@ -182,7 +182,7 @@ int ufshcd_hba_init_crypto_capabilities(struct ufs_hba *hba)
        err = blk_ksm_init(&hba->ksm,
                           hba->crypto_capabilities.config_count + 1);
        if (err)
-               goto out_free_caps;
+               goto out;
 
        hba->ksm.ksm_ll_ops = ufshcd_ksm_ops;
        /* UFS only supports 8 bytes for any DUN */
@@ -208,8 +208,6 @@ int ufshcd_hba_init_crypto_capabilities(struct ufs_hba *hba)
 
        return 0;
 
-out_free_caps:
-       devm_kfree(hba->dev, hba->crypto_cap_array);
 out:
        /* Indicate that init failed by clearing UFSHCD_CAP_CRYPTO */
        hba->caps &= ~UFSHCD_CAP_CRYPTO;