Fix coverity issues (CHECKED_RETURN / PW.PARAMETER_HIDDEN)

+ Fix minor aarch64 build warning

[Version] 13.0.79
[Issue Type] Build

Change-Id: Ie7ed49cf73beb95ce5db332d6595aa6c6def27ab

diff --git a/packaging/pulseaudio-modules-tizen.spec b/packaging/pulseaudio-modules-tizen.spec
index 88816a2..dc69171 100644 (file)
--- a/packaging/pulseaudio-modules-tizen.spec
+++ b/packaging/pulseaudio-modules-tizen.spec
@@ -1,6 +1,6 @@
 Name:             pulseaudio-modules-tizen
 Summary:          Pulseaudio modules for Tizen
-Version:          13.0.78
+Version:          13.0.79
 Release:          0
 Group:            Multimedia/Audio
 License:          LGPL-2.1+

diff --git a/src/aec-manager.c b/src/aec-manager.c
index 8ed96b5..c349f71 100644 (file)
--- a/src/aec-manager.c
+++ b/src/aec-manager.c
@@ -144,7 +144,8 @@ static void send_get_param_reply(DBusConnection *conn, DBusMessage *msg, aec_par
     dbus_message_iter_append_basic(&msg_iter, DBUS_TYPE_INT32, &param->nfrags);
     dbus_message_iter_append_basic(&msg_iter, DBUS_TYPE_STRING, &ptr1);
     dbus_message_iter_append_basic(&msg_iter, DBUS_TYPE_STRING, &ptr2);
-    dbus_connection_send(conn, reply, NULL);
+    if (!dbus_connection_send(conn, reply, NULL))
+        pa_log_error("reply send error!");
 
     dbus_message_unref(reply);
 }
@@ -205,8 +206,13 @@ static DBusHandlerResult method_handler_for_vt(DBusConnection *conn, DBusMessage
         r = dbus_message_new_method_return(m);
         if (r) {
             const char *xml = AEC_MANAGER_INTROSPECT_XML;
-            dbus_message_append_args(r, DBUS_TYPE_STRING, &xml, DBUS_TYPE_INVALID);
-            dbus_connection_send((conn), r, NULL);
+            if (dbus_message_append_args(r, DBUS_TYPE_STRING, &xml, DBUS_TYPE_INVALID)) {
+                if (!dbus_connection_send(conn, r, NULL))
+                    pa_log_error("reply send error!");
+            } else {
+                pa_log_error("args append error!");
+            }
+
             dbus_message_unref(r);
         }
     } else {

diff --git a/src/module-tizenaudio-sink.c b/src/module-tizenaudio-sink.c
index a941adf..9dc3226 100644 (file)
--- a/src/module-tizenaudio-sink.c
+++ b/src/module-tizenaudio-sink.c
@@ -438,7 +438,7 @@ static int process_render(struct userdata *u, pa_usec_t now) {
                 u->small_avail_count++;
 
                 if ((u->small_avail_count % SMALL_AVAIL_LOG_PERIOD) == 0)
-                    pa_log_error("avail is too small : %u(repeat count : %llu)", avail, u->small_avail_count);
+                    pa_log_error("avail is too small : %u(repeat count : %" PRIu64 ")", avail, u->small_avail_count);
 
                 break;
             }

diff --git a/src/stream-manager.c b/src/stream-manager.c
index cb12cb9..4b8b1a1 100644 (file)
--- a/src/stream-manager.c
+++ b/src/stream-manager.c
@@ -3172,11 +3172,11 @@ static void check_and_move_streams_by_device_connection_change(pa_stream_manager
             if (is_connected) {
                 uint32_t preemptive_device_id = 0;
                 if (!pa_stream_manager_get_preemptive_device_id(m, stream_type, stream_role, &preemptive_device_id)) {
-                    pa_tz_device *device = pa_device_manager_get_device_by_id(m->dm, preemptive_device_id);
-                    if (device) {
+                    pa_tz_device *_device = pa_device_manager_get_device_by_id(m->dm, preemptive_device_id);
+                    if (_device) {
                         pa_log_debug("Skip moving this stream[%s, idx:%u] set to the preemptive device(%s, id:%u)", stream_role,
                                      (stream_type == STREAM_SINK_INPUT) ? PA_SINK_INPUT(s)->index : PA_SOURCE_OUTPUT(s)->index,
-                                     device->type, preemptive_device_id);
+                                     _device->type, preemptive_device_id);
                         continue;
                     }
                 }