[M67 Dev][Tizen] Fix crashes at webview launch 87/186687/2
authorChandan Padhi <c.padhi@samsung.com>
Mon, 13 Aug 2018 11:13:46 +0000 (16:43 +0530)
committerGerrit Code Review <gerrit@review.ap-northeast-2.compute.internal>
Thu, 16 Aug 2018 06:43:14 +0000 (06:43 +0000)
This commit fixes the crashes during webview launch.

Change-Id: Ieeae889de17c3ca48814dacf1d320a9380719ef3
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
content/zygote/zygote_main_linux.cc
tizen_src/chromium_impl/content/browser/renderer_host/render_widget_host_view_efl.cc
tizen_src/chromium_impl/content/common/paths_efl.cc
tools/v8_context_snapshot/v8_context_snapshot.gni

index 12447a0..8bf29f2 100644 (file)
@@ -160,8 +160,13 @@ static void EnterLayerOneSandbox(service_manager::SandboxLinux* linux_sandbox,
 // It's not just our code which may do so - some system-installed libraries
 // are known to be culprits, e.g. lttng.
 #if !defined(THREAD_SANITIZER)
+#if defined(OS_TIZEN)
+  // TODO: Check why IsSingleThreaded() returns false for tizen port.
+  DCHECK(sandbox::ThreadHelpers::IsSingleThreaded());
+#else
   CHECK(sandbox::ThreadHelpers::IsSingleThreaded());
 #endif
+#endif
 
   sandbox::SetuidSandboxClient* setuid_sandbox =
       linux_sandbox->setuid_sandbox_client();
index c79d0e7..ab25eff 100644 (file)
@@ -637,6 +637,7 @@ void RenderWidgetHostViewEfl::OnDidHandleKeyEvent(
 }
 
 void RenderWidgetHostViewEfl::UpdateCursor(const WebCursor& webcursor) {
+#if !defined(EWK_BRINGUP)  // FIXME: m67 bringup
   if (is_loading_) {
 // Setting native Loading cursor
 #if defined(USE_WAYLAND)
@@ -658,6 +659,7 @@ void RenderWidgetHostViewEfl::UpdateCursor(const WebCursor& webcursor) {
                               ecore_x_cursor_shape_get(cursor_type));
 #endif
   }
+#endif  // EWK_BRINGUP
 }
 
 void RenderWidgetHostViewEfl::SetIsLoading(bool is_loading) {
index 6fe0acd..952c115 100644 (file)
@@ -147,6 +147,7 @@ bool PathProvider(int key, base::FilePath* result) {
   switch (key) {
 #ifdef OS_TIZEN
     case base::DIR_EXE:
+    case base::DIR_MODULE:
       *result = base::FilePath(kExePath);
       return true;
 #endif
index 6a6f477..828c366 100644 (file)
@@ -15,8 +15,8 @@ declare_args() {
   # TODO(crbug.com/764576): Enable the feature on more environments.
   # Disable in win/cross builds since buliding Blink twice is slow.
   use_v8_context_snapshot =
-      !is_chromeos && !is_android && !is_chromecast && !is_fuchsia &&
-      !(host_os == "mac" && current_cpu == "x86") &&
+      !is_chromeos && !is_android && !is_tizen && !is_chromecast &&
+      !is_fuchsia && !(host_os == "mac" && current_cpu == "x86") &&
       (v8_target_cpu == target_cpu || is_msan) && !(is_win && host_os != "win")
 }