projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a5911ac
)
ASoC: q6asm: add command opcode to timeout error report
author
Srinivas Kandagatla
<srinivas.kandagatla@linaro.org>
Tue, 7 Jul 2020 16:36:31 +0000
(17:36 +0100)
committer
Mark Brown
<broonie@kernel.org>
Wed, 8 Jul 2020 14:57:25 +0000
(15:57 +0100)
Make the error reporting more useful by adding opcode to it.
Without this its almost impossible to say which command actually
timed out.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link:
https://lore.kernel.org/r/20200707163641.17113-2-srinivas.kandagatla@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/qdsp6/q6asm.c
patch
|
blob
|
history
diff --git
a/sound/soc/qcom/qdsp6/q6asm.c
b/sound/soc/qcom/qdsp6/q6asm.c
index ae4b2cabdf2d6cc69ffc33fdf5cab45e61ff5c36..e0983970cba90464331f8bd7286f6087a56e6b93 100644
(file)
--- a/
sound/soc/qcom/qdsp6/q6asm.c
+++ b/
sound/soc/qcom/qdsp6/q6asm.c
@@
-311,7
+311,7
@@
static int q6asm_apr_send_session_pkt(struct q6asm *a, struct audio_client *ac,
5 * HZ);
if (!rc) {
- dev_err(a->dev, "CMD
timeout\n"
);
+ dev_err(a->dev, "CMD
%x timeout\n", hdr->opcode
);
rc = -ETIMEDOUT;
} else if (ac->result.status > 0) {
dev_err(a->dev, "DSP returned error[%x]\n",
@@
-891,7
+891,7
@@
static int q6asm_ac_send_cmd_sync(struct audio_client *ac, struct apr_pkt *pkt)
rc = wait_event_timeout(ac->cmd_wait,
(ac->result.opcode == hdr->opcode), 5 * HZ);
if (!rc) {
- dev_err(ac->dev, "CMD
timeout\n"
);
+ dev_err(ac->dev, "CMD
%x timeout\n", hdr->opcode
);
rc = -ETIMEDOUT;
goto err;
}