eina: fix destruction of the osx semaphores

Well... that's just embarassing... semaphore_destroy() actually takes
the mach task as its first parameter, not the second. This core
amazingly worked very fine on macOS earlier than Sierra.

Fixes T5245

diff --git a/src/lib/eina/eina_lock.c b/src/lib/eina/eina_lock.c
index 3423852..7681936 100644 (file)
--- a/src/lib/eina/eina_lock.c
+++ b/src/lib/eina/eina_lock.c
@@ -303,7 +303,7 @@ _eina_semaphore_free(Eina_Semaphore *sem)
    if (sem)
      {
 #if defined(EINA_HAVE_OSX_SEMAPHORE)
-        return (semaphore_destroy(*sem, mach_task_self()) == KERN_SUCCESS)
+        return (semaphore_destroy(mach_task_self(), *sem) == KERN_SUCCESS)
         ? EINA_TRUE : EINA_FALSE;
 #else
         return (sem_destroy(sem) == 0) ? EINA_TRUE : EINA_FALSE;