serial: Make hw_stopped bool

Convert hw_stopped in uart_port to bool because its more appropriate
type for how it is used.

Also convert the local variable in uart_change_line_settings() caching
old hw_stopped to bool.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20230309080923.11778-7-ilpo.jarvinen@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index ecdc5d9cdb530ed13edcded7c27f1f89b5a14ed3..31b69e61e71de1968d0d382ec29034d86ee0d9ae 100644 (file)
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -182,7 +182,7 @@ static void uart_change_line_settings(struct tty_struct *tty, struct uart_state
 {
        struct uart_port *uport = uart_port_check(state);
        struct ktermios *termios;
-       int hw_stopped;
+       bool hw_stopped;
 
        /*
         * If we have no tty, termios, or the port does not exist,
@@ -3304,13 +3304,13 @@ void uart_handle_cts_change(struct uart_port *uport, bool active)
        if (uart_softcts_mode(uport)) {
                if (uport->hw_stopped) {
                        if (active) {
-                               uport->hw_stopped = 0;
+                               uport->hw_stopped = false;
                                uport->ops->start_tx(uport);
                                uart_write_wakeup(uport);
                        }
                } else {
                        if (!active) {
-                               uport->hw_stopped = 1;
+                               uport->hw_stopped = true;
                                uport->ops->stop_tx(uport);
                        }
                }

diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
index 05d18a145b3a4fe937e961230f86718502d56b85..66ecec15a1bf3d7fcd6b3808196d547e7d0f9b4a 100644 (file)
--- a/include/linux/serial_core.h
+++ b/include/linux/serial_core.h
@@ -553,7 +553,7 @@ struct uart_port {
 #define UPSTAT_AUTOXOFF                ((__force upstat_t) (1 << 4))
 #define UPSTAT_SYNC_FIFO       ((__force upstat_t) (1 << 5))
 
-       int                     hw_stopped;             /* sw-assisted CTS flow state */
+       bool                    hw_stopped;             /* sw-assisted CTS flow state */
        unsigned int            mctrl;                  /* current modem ctrl settings */
        unsigned int            frame_time;             /* frame timing in ns */
        unsigned int            type;                   /* port type */