misc: eeprom: 93xx46: clean up eeprom_93xx46_bin_read/write
authorVladimir Zapolskiy <vz@mleia.com>
Sun, 26 Jul 2015 21:18:48 +0000 (00:18 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Aug 2015 20:53:40 +0000 (13:53 -0700)
The change removes redundant sysfs binary file boundary checks, since
this task is already done on caller side in fs/sysfs/file.c

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/eeprom/eeprom_93xx46.c

index 9ebeacd..a6bd9e3 100644 (file)
@@ -48,13 +48,6 @@ eeprom_93xx46_bin_read(struct file *filp, struct kobject *kobj,
        dev = container_of(kobj, struct device, kobj);
        edev = dev_get_drvdata(dev);
 
-       if (unlikely(off >= edev->bin.size))
-               return 0;
-       if ((off + count) > edev->bin.size)
-               count = edev->bin.size - off;
-       if (unlikely(!count))
-               return count;
-
        cmd_addr = OP_READ << edev->addrlen;
 
        if (edev->addrlen == 7) {
@@ -200,13 +193,6 @@ eeprom_93xx46_bin_write(struct file *filp, struct kobject *kobj,
        dev = container_of(kobj, struct device, kobj);
        edev = dev_get_drvdata(dev);
 
-       if (unlikely(off >= edev->bin.size))
-               return -EFBIG;
-       if ((off + count) > edev->bin.size)
-               count = edev->bin.size - off;
-       if (unlikely(!count))
-               return count;
-
        /* only write even number of bytes on 16-bit devices */
        if (edev->addrlen == 6) {
                step = 2;