pinctrl: Fix return value about devm_platform_ioremap_resource()
authorTiezhu Yang <yangtiezhu@loongson.cn>
Sat, 23 May 2020 11:45:25 +0000 (19:45 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 25 May 2020 11:40:47 +0000 (13:40 +0200)
When call function devm_platform_ioremap_resource(), we should use IS_ERR()
to check the return value and return PTR_ERR() if failed.

Fixes: 4b024225c4a8 ("pinctrl: use devm_platform_ioremap_resource() to simplify code")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Link: https://lore.kernel.org/r/1590234326-2194-1-git-send-email-yangtiezhu@loongson.cn
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/bcm/pinctrl-bcm281xx.c
drivers/pinctrl/pinctrl-at91-pio4.c

index f690fc5cd6885149bee5d0b84ac37cfd787cde8c..71e666178300656cb3723241687edf2ae2d03c53 100644 (file)
@@ -1406,7 +1406,7 @@ static int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
        pdata->reg_base = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(pdata->reg_base)) {
                dev_err(&pdev->dev, "Failed to ioremap MEM resource\n");
-               return -ENODEV;
+               return PTR_ERR(pdata->reg_base);
        }
 
        /* Initialize the dynamic part of pinctrl_desc */
index 694912409fd9efbcb0970b0f59b44b2755c692f3..54222ccddfb190df242207097d263b8bb25a1414 100644 (file)
@@ -1019,7 +1019,7 @@ static int atmel_pinctrl_probe(struct platform_device *pdev)
 
        atmel_pioctrl->reg_base = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(atmel_pioctrl->reg_base))
-               return -EINVAL;
+               return PTR_ERR(atmel_pioctrl->reg_base);
 
        atmel_pioctrl->clk = devm_clk_get(dev, NULL);
        if (IS_ERR(atmel_pioctrl->clk)) {