mt76: move spin_lock_bh to spin_lock in tasklet
authorXingbang Liu <liu.airalert@gmail.com>
Fri, 10 Sep 2021 05:39:28 +0000 (13:39 +0800)
committerFelix Fietkau <nbd@nbd.name>
Wed, 20 Oct 2021 08:36:42 +0000 (10:36 +0200)
as you are already in a tasklet, it is unnecessary to call spin_lock_bh.

Signed-off-by: Xingbang Liu <liu.airalert@gmail.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt76x02_mmio.c

index f4451fb..468be65 100644 (file)
@@ -53,7 +53,7 @@ static void mt76x02_pre_tbtt_tasklet(struct tasklet_struct *t)
                mt76_skb_set_moredata(data.tail[i], false);
        }
 
-       spin_lock_bh(&q->lock);
+       spin_lock(&q->lock);
        while ((skb = __skb_dequeue(&data.q)) != NULL) {
                struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
                struct ieee80211_vif *vif = info->control.vif;
@@ -61,7 +61,7 @@ static void mt76x02_pre_tbtt_tasklet(struct tasklet_struct *t)
 
                mt76_tx_queue_skb(dev, q, skb, &mvif->group_wcid, NULL);
        }
-       spin_unlock_bh(&q->lock);
+       spin_unlock(&q->lock);
 }
 
 static void mt76x02e_pre_tbtt_enable(struct mt76x02_dev *dev, bool en)