fuse: write back dirty pages before direct write in direct_io_relax mode
authorHao Xu <howeyxu@tencent.com>
Tue, 1 Aug 2023 08:06:47 +0000 (16:06 +0800)
committerMiklos Szeredi <mszeredi@redhat.com>
Wed, 16 Aug 2023 10:39:24 +0000 (12:39 +0200)
In direct_io_relax mode, there can be shared mmaped files and thus dirty
pages in its page cache.  Therefore those dirty pages should be written
back to backend before direct io to avoid data loss.

Signed-off-by: Hao Xu <howeyxu@tencent.com>
Reviewed-by: Jiachen Zhang <zhangjiachen.jaycee@bytedance.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
fs/fuse/file.c

index e6034ce..1cdb632 100644 (file)
@@ -1448,6 +1448,13 @@ ssize_t fuse_direct_io(struct fuse_io_priv *io, struct iov_iter *iter,
        if (!ia)
                return -ENOMEM;
 
+       if (fopen_direct_io && fc->direct_io_relax) {
+               res = filemap_write_and_wait_range(mapping, pos, pos + count - 1);
+               if (res) {
+                       fuse_io_free(ia);
+                       return res;
+               }
+       }
        if (!cuse && fuse_range_is_writeback(inode, idx_from, idx_to)) {
                if (!write)
                        inode_lock(inode);